Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🐛 Update connection name - fix minor issues #13550

Merged
merged 31 commits into from
Jul 8, 2022
Merged

🪟 🐛 Update connection name - fix minor issues #13550

merged 31 commits into from
Jul 8, 2022

Commits on Jun 6, 2022

  1. align text to center in edit mode

    @dizel852
    dizel852 committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    f42d251 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. fix firing onChange event twice

    @dizel852
    dizel852 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    97516f2 View commit details
    Browse the repository at this point in the history

  2. fix wrong prop drilling

    @dizel852
    dizel852 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    4558bdd View commit details
    Browse the repository at this point in the history

  3. fix issues: 

    - unable to delete last chart in input
- delete the whole name by 'select all' command
- trim entered names
- don't allow to save empty names
    @dizel852
    dizel852 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    6d3e6cc View commit details
    Browse the repository at this point in the history

  4. remove debug from test

    @dizel852
    dizel852 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    151aaff View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into vlad/13416-connections-rename-fix-minor-is… 

    …sues

# Conflicts:
#	airbyte-webapp/src/pages/ConnectionPage/pages/ConnectionItemPage/components/ConnectionName.tsx
#	airbyte-webapp/src/utils/addEnterEscFuncForInput.tsx
    @dizel852
    dizel852 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    f43d8f9 View commit details
    Browse the repository at this point in the history

  6. remove unused import

    @dizel852
    dizel852 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    4b4214a View commit details
    Browse the repository at this point in the history

  7. update tests due to changes in base Input component

    @dizel852
    dizel852 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    7d11160 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into vlad/13416-connections-rename-fix-minor-is… 

    …sues
    @dizel852
    dizel852 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    55acf12 View commit details
    Browse the repository at this point in the history

  9. reorder default input data-testId in order to have ability to overwri… 

    …te it
    @dizel852
    dizel852 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    c06c977 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into vlad/13416-connections-rename-fix-minor-is… 

    …sues
    @dizel852
    dizel852 authored Jun 7, 2022
    Configuration menu
    Copy the full SHA
    26baa4e View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Merge branch 'master' into vlad/13416-connections-rename-fix-minor-is… 

    …sues
    @dizel852
    dizel852 authored Jun 10, 2022
    Configuration menu
    Copy the full SHA
    00406e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Merge branch 'master' into vlad/13416-connections-rename-fix-minor-is… 

    …sues
    @dizel852
    dizel852 committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    8c7c55a View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. fix e2e tests

    @dizel852
    dizel852 committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    00edb2b View commit details
    Browse the repository at this point in the history

  2. Improvements: 

    - replace "props: any" with right types
- rename 'addEnterEscFuncForInput' to more general and self-describable name
    @dizel852
    dizel852 committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    0183461 View commit details
    Browse the repository at this point in the history

  3. replace styled components with scss modules

    @dizel852
    dizel852 committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    5ad3ef8 View commit details
    Browse the repository at this point in the history

  4. add eslint-plugin-css-modules rules

    @dizel852
    dizel852 committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    0333a70 View commit details
    Browse the repository at this point in the history

  5. Fixes: 

    - turn on eslint css modules rule as error
- remove unused styles
    @dizel852
    dizel852 committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    d7fb68a View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Merge branch 'master' into vlad/13416-connections-rename-fix-minor-is… 

    …sues

# Conflicts:
#	airbyte-webapp/src/pages/ConnectionPage/pages/ConnectionItemPage/components/ConnectionName.tsx
    @dizel852
    dizel852 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    9ab44ea View commit details
    Browse the repository at this point in the history

  2. minor fix after master merge

    @dizel852
    dizel852 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    9c68545 View commit details
    Browse the repository at this point in the history

  3. Revert "Fixes:" 

    This reverts commit d7fb68a.
    @dizel852
    dizel852 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    048878d View commit details
    Browse the repository at this point in the history

  4. Revert "add eslint-plugin-css-modules rules" 

    This reverts commit 0333a70.
    @dizel852
    dizel852 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    9607163 View commit details
    Browse the repository at this point in the history

  5. apply suggested changes after PR review

    @dizel852
    dizel852 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    adf089a View commit details
    Browse the repository at this point in the history

  6. add updates due to changes in PR #13914

    @dizel852
    dizel852 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    08426d6 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Merge branch 'master' into vlad/13416-connections-rename-fix-minor-is… 

    …sues

# Conflicts:
#	airbyte-webapp/src/pages/ConnectionPage/pages/ConnectionItemPage/components/ConnectionName.tsx
    @dizel852
    dizel852 committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    a6b993d View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Merge branch 'master' into vlad/13416-connections-rename-fix-minor-is… 

    …sues
    @dizel852
    dizel852 committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    b84f416 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Merge branch 'master' into vlad/13416-connections-rename-fix-minor-is… 

    …sues
    @dizel852
    dizel852 committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    bc9ab5f View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. add react-app-rewired to tweak webpack config and fix the css order i… 

    …ssue
    @dizel852
    dizel852 committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    81d7ba4 View commit details
    Browse the repository at this point in the history

  2. remove test flag "CI=true"

    @dizel852
    dizel852 committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    2465eee View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. Revert "add react-app-rewired to tweak webpack config and fix the css… 

    … order issue"

This reverts commit 81d7ba4
    @dizel852
    dizel852 committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    bc52d63 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Merge branch 'master' into vlad/13416-connections-rename-fix-minor-is… 

    …sues
    @dizel852
    dizel852 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    33e4edf View commit details
    Browse the repository at this point in the history