Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Webflow #13617

Merged
merged 31 commits into from
Jun 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
4c8c858
Added webflow code
Jun 8, 2022
f529170
Updated readme
Jun 8, 2022
a9ae598
Updated README
Jun 8, 2022
0038cef
Added webflow to source_definitions.yaml
Jun 9, 2022
75fb549
Enhanced documentation for the Webflow source connector
Jun 9, 2022
d0a6b66
Improved webflow source connector instructions
Jun 9, 2022
290214b
Moved Site ID to before API token in Spec.yaml (for presentation in t…
Jun 13, 2022
20e34c1
Addressed comments in PR.
Jun 14, 2022
6d5ffb7
Changes to address requests in PR review
Jun 14, 2022
9d9085e
Removed version from config
Jun 14, 2022
cb69d9e
Minor udpate to spec.yaml for clarity
Jun 14, 2022
7be5dc1
Updated to pass the accept-version as a constant rather than parameter
Jun 15, 2022
ec08110
Updated check_connection to hit the collections API that requires bot…
Jun 15, 2022
1ed9246
Fixed the test_check_connection to use the new check_connection function
Jun 15, 2022
1956e9c
Added a streams test for generate_streams
Jun 15, 2022
227681d
Re-named "autentication" object to "auth" to be more consistent with …
Jun 16, 2022
8b7e4e0
Added in an explict line to instantiante an "auth" object from Webflo…
Jun 16, 2022
976bb11
Fixed a typo in a comment
Jun 16, 2022
2792447
Renamed some classes to be more intuitive
Jun 16, 2022
736cbb0
Renamed class to be more intuitive
Jun 16, 2022
be27cda
Minor change to an internal method name
Jun 16, 2022
fdca660
Made _get_collection_name_to_id_dict staticmethod
Jun 16, 2022
d4a4293
Fixed a unit-test error that only appeared when running " python -m p…
Jun 17, 2022
079ddde
format: add double quotes and remove unused import
sajarin Jun 17, 2022
6cf907c
readme: remove semantic version naming of connector in build commands
sajarin Jun 17, 2022
502727d
Updated spec.yaml
Jun 21, 2022
18ebe69
auto-bump connector version
octavia-squidington-iii Jun 21, 2022
e29eedb
format files
marcosmarxm Jun 22, 2022
5187b76
add changelog
marcosmarxm Jun 22, 2022
3be2744
update dockerfile
marcosmarxm Jun 22, 2022
ff9f332
auto-bump connector version
octavia-squidington-iii Jun 22, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,13 @@
icon: victorops.svg
sourceType: api
releaseStage: alpha
- name: Webflow
sourceDefinitionId: ef580275-d9a9-48bb-af5e-db0f5855be04
dockerRepository: airbyte/source-webflow
dockerImageTag: 0.1.1
documentationUrl: https://docs.airbyte.io/integrations/sources/webflow
sourceType: api
releaseStage: alpha
- name: Zendesk Chat
sourceDefinitionId: 40d24d0f-b8f9-4fe0-9e6c-b06c0f3f45e4
dockerRepository: airbyte/source-zendesk-chat
Expand Down
29 changes: 29 additions & 0 deletions airbyte-config/init/src/main/resources/seed/source_specs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9445,6 +9445,35 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-webflow:0.1.1"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/sources/webflow"
connectionSpecification:
$schema: "http://json-schema.org/draft-07/schema#"
title: "Webflow Spec"
type: "object"
required:
- "api_key"
- "site_id"
additionalProperties: false
properties:
site_id:
title: "Site id"
type: "string"
description: "The id of the Webflow site you are requesting data from. See\
\ https://developers.webflow.com/#sites"
example: "a relatively long hex sequence"
order: 0
api_key:
title: "API token"
type: "string"
description: "The API token for authenticating to Webflow. See https://university.webflow.com/lesson/intro-to-the-webflow-api"
example: "a very long hex sequence"
order: 1
airbyte_secret: true
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-zendesk-chat:0.1.7"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/sources/zendesk-chat"
Expand Down
6 changes: 6 additions & 0 deletions airbyte-integrations/connectors/source-webflow/.dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
*
!Dockerfile
!main.py
!source_webflow
!setup.py
!secrets
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-webflow/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.venv
38 changes: 38 additions & 0 deletions airbyte-integrations/connectors/source-webflow/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
FROM python:3.9.11-alpine3.15 as base

# build and load all requirements
FROM base as builder
WORKDIR /airbyte/integration_code

# upgrade pip to the latest version
RUN apk --no-cache upgrade \
&& pip install --upgrade pip \
&& apk --no-cache add tzdata build-base


COPY setup.py ./
# install necessary packages to a temporary folder
RUN pip install --prefix=/install .

# build a clean environment
FROM base
WORKDIR /airbyte/integration_code

# copy all loaded and built libraries to a pure basic image
COPY --from=builder /install /usr/local
# add default timezone settings
COPY --from=builder /usr/share/zoneinfo/Etc/UTC /etc/localtime
RUN echo "Etc/UTC" > /etc/timezone

# bash is installed for more convenient debugging.
RUN apk --no-cache add bash

# copy payload code only
COPY main.py ./
COPY source_webflow ./source_webflow

ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.name=airbyte/source-webflow
141 changes: 141 additions & 0 deletions airbyte-integrations/connectors/source-webflow/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
# Webflow Source

This is the repository for the Webflow source connector, written in Python.
For information about how to use this connector within Airbyte, see [Webflow source documentation](https://docs.airbyte.io/integrations/sources/webflow).

## Local development

### Prerequisites
**To iterate on this connector, make sure to complete this prerequisites section.**

#### Minimum Python version required `= 3.9.11`

#### Build & Activate Virtual Environment and install dependencies
From this connector directory, create a virtual environment:
```
python -m venv .venv
```

This will generate a virtualenv for this module in `.venv/`. Make sure this venv is active in your
development environment of choice. To activate it from the terminal, run:
```
source .venv/bin/activate
pip install -r requirements.txt
pip install '.[tests]'
```
If you are in an IDE, follow your IDE's instructions to activate the virtualenv.

Note that while we are installing dependencies from `requirements.txt`, you should only edit `setup.py` for your dependencies. `requirements.txt` is
used for editable installs (`pip install -e`) to pull in Python dependencies from the monorepo and will call `setup.py`.
If this is mumbo jumbo to you, don't worry about it, just put your deps in `setup.py` but install using `pip install -r requirements.txt` and everything
should work as you expect.

#### Building via Gradle
You can also build the connector in Gradle. This is typically used in CI and not needed for your development workflow.

To build using Gradle, from the Airbyte repository root, run:
```
./gradlew :airbyte-integrations:connectors:source-webflow:build
```

#### Create credentials
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.io/integrations/sources/webflow)
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_webflow/spec.yaml` file.
Note that any directory named `secrets` is git-ignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
See `integration_tests/sample_config.json` for a sample config file.

For more information about creating Webflow credentials, see [the documentation](https://docs.airbyte.io/integrations/sources/webflow).

**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source webflow test creds`
and place them into `secrets/config.json`.

### Locally running the connector
```
python main.py spec
python main.py check --config secrets/config.json
python main.py discover --config secrets/config.json
python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json
```

### Locally running the connector docker image

#### Build
First, make sure you build the latest Docker image. Execute the following from
the source-webflow project directory (where Dockerfile can be found):
```
docker build . -t airbyte/source-webflow:dev
```

You can also build the connector image via Gradle:
```
./gradlew :airbyte-integrations:connectors:source-webflow:airbyteDocker
```
When building via Gradle, the docker image name and tag, respectively, are the values of the `io.airbyte.name` and `io.airbyte.version` `LABEL`s in
the Dockerfile.

#### Run
Then run any of the connector commands as follows:
```
docker run --rm airbyte/source-webflow:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-webflow:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-webflow:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-webflow:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
```
## Testing
Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named.
First install test dependencies into your virtual environment:
```
pip install .[tests]
```

Or if you are running in OSX with zsh, you may need to execute the following instead
```
pip install .'[tests]'
```
### Unit Tests
To run unit tests locally, from the connector directory run:
```
python -m pytest unit_tests
```

### Integration Tests
There are two types of integration tests: Acceptance Tests (Airbyte's test suite for all source connectors) and custom integration tests (which are specific to this connector).
#### Custom Integration tests
Place custom tests inside `integration_tests/` folder, then, from the connector root, run
```
python -m pytest integration_tests
```
#### Acceptance Tests
Customize `acceptance-test-config.yml` file to configure tests. See [Source Acceptance Tests](https://docs.airbyte.io/connector-development/testing-connectors/source-acceptance-tests-reference) for more information.
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.
To run your integration tests with acceptance tests, from the connector root, run
```
python -m pytest integration_tests -p integration_tests.acceptance
```
To run your integration tests with docker

### Using gradle to run tests
All commands should be run from airbyte project root.
To run unit tests:
```
./gradlew :airbyte-integrations:connectors:source-webflow:unitTest
```
To run acceptance and custom integration tests:
```
./gradlew :airbyte-integrations:connectors:source-webflow:integrationTest
```

## Dependency Management
All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development.
We split dependencies between two groups, dependencies that are:
* required for your connector to work need to go to `MAIN_REQUIREMENTS` list.
* required for the testing need to go to `TEST_REQUIREMENTS` list

### Publishing a new version of the connector
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
1. Make sure your changes are passing unit and integration tests.
1. Bump the connector version in `Dockerfile` -- just increment the value of the `LABEL io.airbyte.version` appropriately (we use [SemVer](https://semver.org/)).
1. Create a Pull Request.
1. Pat yourself on the back for being an awesome contributor.
1. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# See [Source Acceptance Tests](https://docs.airbyte.io/connector-development/testing-connectors/source-acceptance-tests-reference)
# for more information about how to configure these tests
connector_image: airbyte/source-webflow:dev
tests:
spec:
- spec_path: "source_webflow/spec.yaml"
connection:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
- config_path: "secrets/config.json"
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams: []


Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#!/usr/bin/env sh

# Build latest connector image
docker build . -t $(cat acceptance-test-config.yml | grep "connector_image" | head -n 1 | cut -d: -f2-)

# Pull latest acctest image
docker pull airbyte/source-acceptance-test:latest

# Run
docker run --rm -it \
-v /var/run/docker.sock:/var/run/docker.sock \
-v /tmp:/tmp \
-v $(pwd):/test_input \
airbyte/source-acceptance-test \
--acceptance-test-config /test_input

9 changes: 9 additions & 0 deletions airbyte-integrations/connectors/source-webflow/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
plugins {
id 'airbyte-python'
id 'airbyte-docker'
id 'airbyte-source-acceptance-test'
}

airbytePython {
moduleDirectory 'source_webflow'
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#
# Copyright (c) 2021 Airbyte, Inc., all rights reserved.
#
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"todo-stream-name": {
"todo-field-name": "todo-abnormal-value"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#


import pytest

pytest_plugins = ("source_acceptance_test.plugin",)


@pytest.fixture(scope="session", autouse=True)
def connector_setup():
"""This fixture is a placeholder for external resources that acceptance test might require."""
yield
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"streams": [
{
"stream": {
"name": "Blog Authors",
sajarin marked this conversation as resolved.
Show resolved Hide resolved
"json_schema": {}
},
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite"
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"site_id": "wrong data",
"api_key": "wrong data"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"site_id": "your-webflow-site-id",
"api_key": "your-webflow-token"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"todo-stream-name": {
"todo-field-name": "value"
}
}
13 changes: 13 additions & 0 deletions airbyte-integrations/connectors/source-webflow/main.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#


import sys

from airbyte_cdk.entrypoint import launch
from source_webflow import SourceWebflow

if __name__ == "__main__":
source = SourceWebflow()
launch(source, sys.argv[1:])
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-e ../../bases/source-acceptance-test
-e .
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"streams": [
{
"stream": {
"name": "Blog Authors",
"json_schema": {}
},
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite"
}
]
}
Loading