Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-paypal-transaction: update transaction schema #13682

Merged
merged 15 commits into from
Jun 24, 2022
Merged

source-paypal-transaction: update transaction schema #13682

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
cc0b546
Update Paypal Transactions schema
mohamagdy Jun 10, 2022
79121f5
Bump PayPal Transactions connector version to `0.1.6`
mohamagdy Jun 10, 2022
a0d5eb4
Bump PayPal source version to `0.1.6`
mohamagdy Jun 13, 2022
c00755b
Fix typo in documenation URL in source definitions
mohamagdy Jun 15, 2022
30a7eb3
Merge branch 'master' of https://github.com/airbytehq/airbyte into up…
mohamagdy Jun 17, 2022
fd01719
Set `minLength` for PayPal `currency_code` field
mohamagdy Jun 17, 2022
13d82a9
Set `maxLength` for `custom_field`
mohamagdy Jun 17, 2022
40172fc
Add `transactions` to list of empty streams
mohamagdy Jun 17, 2022
dc05ec1
Updates transaction amount value type to string according to the docs…
Jun 21, 2022
9376ec9
Revert "Updates transaction amount value type to string according to …
Jun 21, 2022
3d6eef3
Update transaction amount value type to string.
Jun 21, 2022
39cf005
Transforms values returned as strings by the API into floats or integ…
Jun 22, 2022
6d0c18d
Updates transaction schema in accordance with the API.
Jun 22, 2022
2039b50
Merge branch 'master' into update-paypal-transaction-schema
alafanechere Jun 24, 2022
f11fb4b
Merge branch 'master' into update-paypal-transaction-schema
alafanechere Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@
- name: Paypal Transaction
sourceDefinitionId: d913b0f2-cc51-4e55-a44c-8ba1697b9239
dockerRepository: airbyte/source-paypal-transaction
dockerImageTag: 0.1.5
dockerImageTag: 0.1.6
mohamagdy marked this conversation as resolved.
Show resolved Hide resolved
documentationUrl: https://docs.airbyte.io/integrations/sources/paypal-transaction
icon: paypal.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6364,7 +6364,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-paypal-transaction:0.1.5"
- dockerImage: "airbyte/source-paypal-transaction:0.1.6"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/sources/paypal-transactions"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-paypal-transaction/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.5
LABEL io.airbyte.version=0.1.6
LABEL io.airbyte.name=airbyte/source-paypal-transaction
160 changes: 105 additions & 55 deletions .../connectors/source-paypal-transaction/source_paypal_transaction/schemas/transactions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,135 +5,166 @@
"transaction_info": {
"type": ["null", "object"],
"properties": {
"paypal_reference_id": {
"type": ["null", "string"],
"maxLength": 24
},
"paypal_reference_id_type": {
"type": ["null", "string"],
"maxLength": 3
mohamagdy marked this conversation as resolved.
Show resolved Hide resolved
},
"protection_eligibility": {
"type": ["null", "string"],
"maxLength": 2
},
"paypal_account_id": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 24
},
"transaction_id": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 24
},
"transaction_event_code": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 5
},
"transaction_initiation_date": {
"type": ["null", "string"]
"type": ["null", "string"],
"format": "date-time"
},
"transaction_updated_date": {
"type": ["null", "string"]
"type": ["null", "string"],
"format": "date-time"
},
"transaction_amount": {
"type": ["null", "object"],
"properties": {
"currency_code": {
"type": ["null", "string"]
"type": "string",
"maxLength": 3
mohamagdy marked this conversation as resolved.
Show resolved Hide resolved
},
"value": {
"type": ["null", "string"]
"type": "number"
mohamagdy marked this conversation as resolved.
Show resolved Hide resolved
}
}
},
"fee_amount": {
"type": ["null", "object"],
"properties": {
"currency_code": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 3
},
"value": {
"type": ["null", "string"]
"type": ["null", "number"]
}
}
},
"insurance_amount": {
"type": ["null", "object"],
"properties": {
"currency_code": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 3
},
"value": {
"type": ["null", "string"]
"type": ["null", "number"]
}
}
},
"shipping_amount": {
"type": ["null", "object"],
"properties": {
"currency_code": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 3
},
"value": {
"type": ["null", "string"]
"type": ["null", "number"]
}
}
},
"shipping_discount_amount": {
"type": ["null", "object"],
"properties": {
"currency_code": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 3
},
"value": {
"type": ["null", "string"]
"type": ["null", "number"]
}
}
},
"transaction_status": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 1
},
"transaction_subject": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 256
},
"transaction_note": {
"type": ["null", "string"]
mohamagdy marked this conversation as resolved.
Show resolved Hide resolved
},
"invoice_id": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 127
},
"custom_field": {
"type": ["null", "string"]
mohamagdy marked this conversation as resolved.
Show resolved Hide resolved
},
"protection_eligibility": {
"type": ["null", "string"]
}
}
},
"payer_info": {
"type": ["null", "object"],
"properties": {
"account_id": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 13
},
"email_address": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 256
},
"address_status": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 1
},
"payer_status": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 1
},
"payer_name": {
"type": ["null", "object"],
"properties": {
"given_name": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 256
Comment on lines +155 to +156
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": ["null", "string"],
"maxLength": 256
"type": ["null", "string"],
"maxLength": 140

},
"surname": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 256
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"maxLength": 256
"maxLength": 140

},
"alternate_full_name": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"alternate_full_name": {

Delete this property as it's been deprecated.

"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 256
}
}
},
"country_code": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"maxLength": 3
"maxLength": 2,
"minLength": 2

}
}
},
"shipping_info": {
"type": ["null", "object"],
"properties": {
"name": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 500
},
"address": {
"type": ["null", "object"],
Expand All @@ -145,13 +176,16 @@
"type": ["null", "string"]
},
"city": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 256
Comment on lines +191 to +192
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": ["null", "string"],
"maxLength": 256
"type": ["string"]

},
"country_code": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 3
Comment on lines +195 to +196
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": ["null", "string"],
"maxLength": 3
"type": ["string"],
"maxLength": 2

},
"postal_code": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 256
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"maxLength": 256

}
}
}
Expand All @@ -166,36 +200,40 @@
"type": ["null", "object"],
"properties": {
"item_code": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 1000
},
"item_name": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 256
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"maxLength": 256
"maxLength": 200

},
"item_description": {
"type": ["null", "string"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 2000

},
"item_quantity": {
"type": ["null", "string"]
"type": ["null", "number"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": ["null", "number"]
"type": ["null", "number"],
"maxLength": 4000

},
"item_unit_price": {
"type": ["null", "object"],
"properties": {
"currency_code": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the currency code and value properties according to the documentation.

"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 3
},
"value": {
"type": ["null", "string"]
"type": ["null", "number"]
}
}
},
"item_amount": {
"type": ["null", "object"],
"properties": {
"currency_code": {
mohamagdy marked this conversation as resolved.
Show resolved Hide resolved
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 3
},
"value": {
"type": ["null", "string"]
"type": ["null", "number"]
}
}
},
Expand All @@ -208,10 +246,11 @@
"type": ["null", "object"],
"properties": {
"currency_code": {
mohamagdy marked this conversation as resolved.
Show resolved Hide resolved
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 3
},
"value": {
"type": ["null", "string"]
"type": ["null", "number"]
}
}
}
Expand All @@ -222,15 +261,17 @@
"type": ["null", "object"],
"properties": {
"currency_code": {
mohamagdy marked this conversation as resolved.
Show resolved Hide resolved
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 3
},
"value": {
"type": ["null", "string"]
"type": ["null", "number"]
}
}
},
"invoice_number": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 200
}
}
}
Expand All @@ -241,27 +282,32 @@
"type": ["null", "object"],
"properties": {
"store_id": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 100
},
"terminal_id": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 60
}
}
},
"auction_info": {
"type": ["null", "object"],
"properties": {
"auction_site": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 200
},
"auction_item_site": {
"type": ["null", "string"]
},
"auction_buyer_id": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 500
},
"auction_closing_date": {
"type": ["null", "string"]
"type": ["null", "string"],
"format": "date-time"
}
}
},
Expand All @@ -274,24 +320,28 @@
"type": "object",
"properties": {
"incentive_type": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 500
},
"incentive_code": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 200
},
"incentive_amount": {
"type": "object",
"properties": {
"currency_code": {
mohamagdy marked this conversation as resolved.
Show resolved Hide resolved
"type": "string"
"type": "string",
"maxLength": 3
},
"value": {
"type": "string"
"type": ["null", "number"]
}
}
},
"incentive_program_code": {
"type": ["null", "string"]
"type": ["null", "string"],
"maxLength": 100
}
}
}
Expand Down
Loading