Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Hubspot: fix URI too long issue #13691

Merged

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/268

How

Before #13596 multiple values of property param were joined with comma, now they are passed as property=x&property=y&property=z, this was not reflected when counting the length of the URI.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 10, 2022
@davydov-d davydov-d self-assigned this Jun 10, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 10, 2022

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2475938302
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2475938302
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_hubspot/errors.py         6      0   100%
source_hubspot/__init__.py       2      0   100%
source_hubspot/streams.py      776     62    92%
source_hubspot/helpers.py       31      3    90%
source_hubspot/source.py        97     21    78%
------------------------------------------------
TOTAL                          912     86    91%

Build Passed

Test summary info:

All Passed

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@ab4028d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head bc0f7ab differs from pull request most recent head 325690d. Consider uploading reports for the commit 325690d to get more accurate results

@@            Coverage Diff            @@
##             master   #13691   +/-   ##
=========================================
  Coverage          ?   90.58%           
=========================================
  Files             ?        5           
  Lines             ?      913           
  Branches          ?        0           
=========================================
  Hits              ?      827           
  Misses            ?       86           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab4028d...325690d. Read the comment docs.

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 10, 2022

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2476993564
🚀 Successfully published connectors/source-hubspot
🚀 Auto-bumped version for connectors/source-hubspot
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2476993564

@davydov-d davydov-d merged commit 5df20b7 into master Jun 10, 2022
@davydov-d davydov-d deleted the ddavydov/#268-oncall-source-hubspot-fix-uri-too-long branch June 10, 2022 19:30
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets June 10, 2022 19:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants