Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 4-connection-checking.md #13812

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Update 4-connection-checking.md #13812

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdf7d5c
Update 4-connection-checking.md
alexander-marquardt Jun 15, 2022
70a29f0
Update 4-connection-checking.md
alexander-marquardt Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...nnector-development/tutorials/cdk-tutorial-python-http/4-connection-checking.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ Following the docstring instructions, we'll change the implementation to verify
return True, None
```

Note: in a real implementation you should write code to connect to the API to validate connectivity and not just validate inputs - for an example see `check_connection` in the [OneSignal source connector implementation](https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-onesignal/source_onesignal/source.py)

Let's test out this implementation by creating two objects: a valid and an invalid config and attempt to give them as input to the connector. For this section, you will need to take the API access key generated earlier and add it to both configs. Because these configs contain secrets, we recommend storing configs which contain secrets in `secrets/config.json` because the `secrets` directory is gitignored by default.

```text
Expand Down