-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove quarantined #13904
Remove quarantined #13904
Conversation
I want to check with Lake if there is some connection that could benefit from the old behavior before merging. |
@benmoriceau do you know how this will affect any connections that are currently in a quarantined state? There could still be some on cloud or on OSS deployments that are currently in quarantined |
@benmoriceau is this a PR we are still trying to move forward with? |
Yes, I would prefer to merge it when the epic about the manual operation related to quarantine is done. @lmossman is right about the potential problem that can occur if we have workflow that are in quarantine. We should avoid that. |
@benmoriceau is this PR still blocked? |
Yes. The airbyte-cron app need to be updated with a call to the temporal service. It was blocked by having the temporal client to be injectable through micronaut. I am working on syncing with @jdpgrailsdev to check if some work needs to happen here. |
Draft because of the conflicts |
What
The possibility of setting a job in quarantine has been remove in #13779.
This PR removes to the quarantine state in the other parts of the codebase since it is not needed.