Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quarantined #13904

Closed
wants to merge 1 commit into from
Closed

Remove quarantined #13904

wants to merge 1 commit into from

Conversation

benmoriceau
Copy link
Contributor

What

The possibility of setting a job in quarantine has been remove in #13779.

This PR removes to the quarantine state in the other parts of the codebase since it is not needed.

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Jun 17, 2022
@benmoriceau
Copy link
Contributor Author

I want to check with Lake if there is some connection that could benefit from the old behavior before merging.

@lmossman
Copy link
Contributor

@benmoriceau do you know how this will affect any connections that are currently in a quarantined state? There could still be some on cloud or on OSS deployments that are currently in quarantined

@cgardens
Copy link
Contributor

@benmoriceau is this a PR we are still trying to move forward with?

@benmoriceau
Copy link
Contributor Author

@benmoriceau is this a PR we are still trying to move forward with?

Yes, I would prefer to merge it when the epic about the manual operation related to quarantine is done. @lmossman is right about the potential problem that can occur if we have workflow that are in quarantine. We should avoid that.

@lmossman lmossman removed their request for review August 12, 2022 17:25
@cgardens
Copy link
Contributor

cgardens commented Sep 6, 2022

@benmoriceau is this PR still blocked?

@benmoriceau
Copy link
Contributor Author

@benmoriceau is this PR still blocked?

Yes. The airbyte-cron app need to be updated with a call to the temporal service. It was blocked by having the temporal client to be injectable through micronaut. I am working on syncing with @jdpgrailsdev to check if some work needs to happen here.

@benmoriceau
Copy link
Contributor Author

@cgardens it will be unblocked once #16414 and #16447 are merged

@benmoriceau benmoriceau removed the request for review from cgardens October 21, 2022 16:20
@benmoriceau benmoriceau marked this pull request as draft October 21, 2022 16:20
@benmoriceau
Copy link
Contributor Author

Draft because of the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants