🐛Source Freshdesk: Update parsing of start_date param #14049

annalvova05 · 2022-06-23T08:31:33Z

What

Sync failed if start_date was not specified in config. Param for incremental sync is passed not in the correct format.

How

Update format of date-time for Incremental Sync.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

annalvova05 · 2022-06-23T08:33:45Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2547826947
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2547826947
🐛 https://gradle.com/s/yotkzeexljuto

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_300_page.py::Test300PageLimit::test_not_all_records - ...
	 �[31m================== �[31m�[1m1 failed�[0m, �[32m39 passed�[0m, �[33m166 warnings�[0m�[31m in 3.97s�[0m�[31m ==================�[0m

…e' into alvova/13328-freshdesk-start-date

annalvova05 · 2022-06-23T12:34:31Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2549151864
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2549151864
🐛 https://gradle.com/s/wcugxe4epjeoy

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
================== 1 failed, 23 passed in 2582.73s (0:43:02) ===================

…esk-start-date

annalvova05 · 2022-07-06T12:09:41Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2622673064
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2622673064
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_freshdesk/source.py        31      0   100%
source_freshdesk/__init__.py       2      0   100%
source_freshdesk/streams.py      210      3    99%
source_freshdesk/utils.py         20      1    95%
--------------------------------------------------
TOTAL                            263      4    98%

Build Passed

Test summary info:

All Passed

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

airbyte-integrations/connectors/source-freshdesk/unit_tests/test_300_page.py

…esk-start-date

annalvova05 · 2022-07-11T15:18:17Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2650589827
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2650589827
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_freshdesk/source.py        31      0   100%
source_freshdesk/__init__.py       2      0   100%
source_freshdesk/streams.py      210      3    99%
source_freshdesk/utils.py         20      1    95%
--------------------------------------------------
TOTAL                            263      4    98%

Build Passed

Test summary info:

All Passed

annalvova05 · 2022-07-11T15:32:06Z

/publish connector=connectors/source-freshdesk

🕑 Publishing the following connectors:
connectors/source-freshdesk
https://github.com/airbytehq/airbyte/actions/runs/2650673322

Connector	Did it publish?	Were definitions generated?
connectors/source-freshdesk	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Upd parsing of start_date

465df73

annalvova05 self-assigned this Jun 23, 2022

github-actions bot added the area/connectors Connector related issues label Jun 23, 2022

octavia-squidington-iii added the connectors/source/freshdesk label Jun 23, 2022

Bump version

d897b07

annalvova05 linked an issue Jun 23, 2022 that may be closed by this pull request

Freshdesk connection: It should be a valid date in the 'combined date and time ISO8601' format #13328

Closed

github-actions bot added the area/documentation Improvements or additions to documentation label Jun 23, 2022

Merge branch 'master' into alvova/13328-freshdesk-start-date

1ff6517

annalvova05 added 3 commits June 23, 2022 11:51

Upd unit tests

d2d8c2d

Merge remote-tracking branch 'origin/alvova/13328-freshdesk-start-dat…

d2dd6e6

…e' into alvova/13328-freshdesk-start-date

Upd timeout

ad8a915

annalvova05 added 3 commits June 23, 2022 16:40

Merge remote-tracking branch 'origin/master' into alvova/13328-freshd…

d6528a7

…esk-start-date

Remove timeout

85703c3

Merge remote-tracking branch 'origin/master' into alvova/13328-freshd…

e2cd612

…esk-start-date

annalvova05 marked this pull request as ready for review July 6, 2022 12:28

annalvova05 requested review from lazebnyi and midavadim July 6, 2022 12:28

lazebnyi approved these changes Jul 7, 2022

View reviewed changes

midavadim reviewed Jul 7, 2022

View reviewed changes

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py Show resolved Hide resolved

airbyte-integrations/connectors/source-freshdesk/unit_tests/test_300_page.py Show resolved Hide resolved

annalvova05 requested a review from midavadim July 7, 2022 12:35

midavadim approved these changes Jul 11, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master' into alvova/13328-freshd…

43fb4bf

…esk-start-date

auto-bump connector version

fc3b791

octavia-squidington-iii temporarily deployed to more-secrets July 11, 2022 15:54 Inactive

Merge branch 'master' into alvova/13328-freshdesk-start-date

a5e2f29

annalvova05 merged commit 4e80a67 into master Jul 11, 2022

annalvova05 deleted the alvova/13328-freshdesk-start-date branch July 11, 2022 15:56

annalvova05 temporarily deployed to more-secrets July 11, 2022 15:58 Inactive

octavia-squidington-iii mentioned this pull request Jul 13, 2022

Bump Airbyte version from 0.39.35-alpha to 0.39.36-alpha #14690

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛Source Freshdesk: Update parsing of start_date param #14049

🐛Source Freshdesk: Update parsing of start_date param #14049

annalvova05 commented Jun 23, 2022

annalvova05 commented Jun 23, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jun 23, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jul 6, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jul 11, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jul 11, 2022 •

edited by github-actions bot

Loading

🐛Source Freshdesk: Update parsing of start_date param #14049

🐛Source Freshdesk: Update parsing of start_date param #14049

Conversation

annalvova05 commented Jun 23, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

annalvova05 commented Jun 23, 2022 • edited by github-actions bot Loading

Build Failed

annalvova05 commented Jun 23, 2022 • edited by github-actions bot Loading

Build Failed

annalvova05 commented Jul 6, 2022 • edited by github-actions bot Loading

Build Passed

annalvova05 commented Jul 11, 2022 • edited by github-actions bot Loading

Build Passed

annalvova05 commented Jul 11, 2022 • edited by github-actions bot Loading

annalvova05 commented Jun 23, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jun 23, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jul 6, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jul 11, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jul 11, 2022 •

edited by github-actions bot

Loading