-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Source Freshdesk: Update parsing of start_date param #14049
Conversation
/test connector=connectors/source-freshdesk
Build FailedTest summary info:
|
…e' into alvova/13328-freshdesk-start-date
/test connector=connectors/source-freshdesk
Build FailedTest summary info:
|
/test connector=connectors/source-freshdesk
Build PassedTest summary info:
|
airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-freshdesk/unit_tests/test_300_page.py
Show resolved
Hide resolved
/test connector=connectors/source-freshdesk
Build PassedTest summary info:
|
/publish connector=connectors/source-freshdesk
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Sync failed if
start_date
was not specified in config. Param for incremental sync is passed not in the correct format.How
Update format of date-time for Incremental Sync.
Recommended reading order
streams.py
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.