Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Elasticsearch #14118

Merged
merged 16 commits into from
Jul 12, 2022

Conversation

nilkamalthakuria
Copy link
Contributor

@nilkamalthakuria nilkamalthakuria commented Jun 24, 2022

What

In this PR I am adding a new source Elasticsearch connector.

How

Written in Java using Elasticsearch's High Level Rest Client HLRC

Recommended reading order

  1. ElasticsearchSource.java
  2. ElasticsearchConnection.java
  3. ElasticsearchTypeMapper.java

🚨 User Impact 🚨

New connector now has type mappings for objects, which are handled recursively, along with other Elasticsearch data types.
The previous PR lacked this feature.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit Screen Shot 2022-06-24 at 12 31 49 PM
Integration Screen Shot 2022-07-01 at 11 40 24 AM
Acceptance

@CLAassistant
Copy link

CLAassistant commented Jun 24, 2022

CLA assistant check
All committers have signed the CLA.

@nilkamalthakuria nilkamalthakuria changed the title New source elasticsearch New Source: Elasticsearch Jun 24, 2022
@marcosmarxm
Copy link
Member

marcosmarxm commented Jun 27, 2022

Would be grateful if someone could point me the fix for the missing docker image. I built the connector using docker build . -t airbyte/source-elasticsearch:dev, but it shows as missing during integration testing.

Please run ./gradlew airbyte-integrations:connectors:source-elasticsearch:integrationTest

@alafanechere alafanechere added the bounty-XL Maintainer program: claimable extra large bounty PR label Jun 28, 2022
@alafanechere alafanechere changed the title New Source: Elasticsearch 🎉 New Source: Elasticsearch Jun 28, 2022
@marcosmarxm marcosmarxm self-assigned this Jun 29, 2022
@nilkamalthakuria
Copy link
Contributor Author

@marcosmarxm Here are the acceptance test logs. Screenshot is attached in the first comment.
Test Results — ElasticsearchSourceAcceptanceTest .pdf

@marcosmarxm
Copy link
Member

marcosmarxm commented Jul 5, 2022

/test connector=connectors/source-elasticsearch

🕑 connectors/source-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/2616397557
✅ connectors/source-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/2616397557
No Python unittests run

Build Passed

Test summary info:

All Passed

@marcosmarxm
Copy link
Member

marcosmarxm commented Jul 12, 2022

/test connector=connectors/source-elasticsearch

🕑 connectors/source-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/2658984509
❌ connectors/source-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/2658984509
🐛 https://gradle.com/s/sgrdt3i6az5fu

Build Failed

Test summary info:

Could not find result summary

@marcosmarxm
Copy link
Member

marcosmarxm commented Jul 12, 2022

/test connector=connectors/source-elasticsearch

🕑 connectors/source-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/2659114685
✅ connectors/source-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/2659114685
No Python unittests run

Build Passed

Test summary info:

All Passed

@marcosmarxm
Copy link
Member

marcosmarxm commented Jul 12, 2022

/publish connector=connectors/source-elasticsearch

🕑 Publishing the following connectors:
connectors/source-elasticsearch
https://github.com/airbytehq/airbyte/actions/runs/2659176386


Connector Did it publish? Were definitions generated?
connectors/source-elasticsearch

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty bounty-XL Maintainer program: claimable extra large bounty PR community connectors/source/elasticsearch reward-200
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

6 participants