Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send sentry releases to new project for incident management #14123

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Send sentry releases to new project for incident management #14123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0f878f
update sentry release script
Phlair Jun 24, 2022
26c1cc8
Merge branch 'master' into george/sentry-connector-releases
Phlair Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions .github/workflows/publish-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,14 +283,6 @@ jobs:
if: startsWith(matrix.connector, 'connectors')
run: |
curl -sL https://sentry.io/get-cli/ | bash || echo "sentry cli already installed"
- name: Create Sentry Release
if: startsWith(matrix.connector, 'connectors')
run: |
sentry-cli releases set-commits "${{ env.IMAGE_NAME }}@${{ env.IMAGE_VERSION }}" --auto --ignore-missing
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_CONNECTOR_RELEASE_AUTH_TOKEN }}
SENTRY_ORG: airbyte-5j
SENTRY_PROJECT: airbyte-connectors
- name: Publish ${{ matrix.connector }}
run: |
echo "$SPEC_CACHE_SERVICE_ACCOUNT_KEY" > spec_cache_key_file.json && docker login -u ${DOCKER_HUB_USERNAME} -p ${DOCKER_HUB_PASSWORD}
Expand All @@ -301,14 +293,16 @@ jobs:
DOCKER_HUB_PASSWORD: ${{ secrets.DOCKER_HUB_PASSWORD }}
# Oracle expects this variable to be set. Although usually present, this is not set by default on Github virtual runners.
TZ: UTC
- name: Finalize Sentry release
if: startsWith(matrix.connector, 'connectors')
- name: Create Sentry Release
if: startsWith(matrix.connector, 'connectors') && success()
run: |
sentry-cli releases finalize "${{ env.IMAGE_NAME }}@${{ env.IMAGE_VERSION }}"
SENTRY_RELEASE_NAME="airbyte-${{ env.IMAGE_NAME }}@${{ env.IMAGE_VERSION }}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now I've just hardcoded airbyte- but this will likely need a rethink at the point where we're not just having airbyte- connectors. Since we're not there yet it feels superfluous to add logic for that already.

sentry-cli releases set-commits "$SENTRY_RELEASE_NAME" --auto --ignore-missing &&
sentry-cli releases finalize "$SENTRY_RELEASE_NAME"
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_CONNECTOR_RELEASE_AUTH_TOKEN }}
SENTRY_ORG: airbyte-5j
SENTRY_PROJECT: airbyte-connectors
SENTRY_PROJECT: connector-incident-management
- name: Check if connector in definitions yaml
if: github.event.inputs.auto-bump-version == 'true' && success()
run: |
Expand Down