Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the old scheduler from HelmCharts helper #14187

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Remove the old scheduler from HelmCharts helper #14187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8077aa
Remove the old scheduler from HelmCharts helper
mohamagdy Jun 27, 2022
f49a79b
Remove legacy `scheduler` comment in HelmCharts
mohamagdy Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions charts/airbyte/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,13 +179,6 @@ Returns the GCP credentials path
{{- end -}}
{{- end -}}

{{/*
Returns the Airbyte Scheduler Image
*/}}
{{- define "airbyte.schedulerImage" -}}
{{- include "common.images.image" (dict "imageRoot" .Values.scheduler.image "global" .Values.global) -}}
{{- end -}}

{{/*
Returns the Airbyte Server Image
*/}}
Expand Down
2 changes: 1 addition & 1 deletion charts/airbyte/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,7 +832,7 @@ logs:
## @param logs.gcs.credentialsJson Base64 encoded json GCP credentials file contents
gcs:
bucket: ""
# If you are mounting an existing secret to extraVolumes on scheduler, server and worker
# If you are mounting an existing secret to extraVolumes on server and worker
# deployments, then set credentials to the path of the mounted JSON file
credentials: ""
# If credentialsJson is set then credentials auto resolves (to /secrets/gcs-log-creds/gcp.json)
Expand Down