Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🎨 Front end/Design tweaks #14257

Merged
merged 2 commits into from
Jul 8, 2022
Merged

🪟 🎨 Front end/Design tweaks #14257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecfff3c
updates from pairing
teallarson Jun 29, 2022
6f6707b
cleanup from review
teallarson Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions airbyte-webapp/src/components/ConnectorIcon/ConnectorIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,14 @@ interface Props {
small?: boolean;
}

export const Content = styled.div<{ $small?: boolean }>`
export const Content = styled.div`
height: 25px;
width: 25px;
border-radius: ${({ $small }) => ($small ? 0 : 50)}%;
overflow: hidden;
`;

export const ConnectorIcon: React.FC<Props> = ({ icon, className, small }) => (
<Content className={className} $small={small} aria-hidden="true">
export const ConnectorIcon: React.FC<Props> = ({ icon, className }) => (
<Content className={className} aria-hidden="true">
{getIcon(icon)}
</Content>
);
2 changes: 1 addition & 1 deletion airbyte-webapp/src/components/ContentCard/ContentCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface IProps {
const Title = styled(H5)<{ light?: boolean }>`
padding: ${({ light }) => (light ? "19px 20px 20px" : "25px 25px 22px")};
color: ${({ theme }) => theme.darkPrimaryColor};
box-shadow: ${({ light, theme }) => (light ? "none" : `0 1px 2px ${theme.shadowColor}`)};
border-bottom: ${({ light }) => (light ? "none" : "#e8e8ed 1px solid")};
font-weight: 600;
letter-spacing: 0.008em;
border-radius: 10px 10px 0 0;
Expand Down
2 changes: 1 addition & 1 deletion airbyte-webapp/src/components/EntityTable/components/ConnectorCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const Image = styled(ConnectorIcon)`
const ConnectorCell: React.FC<IProps> = ({ value, enabled, img }) => {
return (
<Content enabled={enabled}>
<Image small icon={img} />
<Image icon={img} />
{value}
</Content>
);
Expand Down
2 changes: 1 addition & 1 deletion airbyte-webapp/src/components/EntityTable/components/NameCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const NameCell: React.FC<Props> = ({ value, enabled, status, icon, img }) => {
return (
<Content>
{status ? <StatusIcon title={title} status={statusIconStatus} /> : <Space />}
{icon && <Image small icon={img} />}
{icon && <Image icon={img} />}
<Name enabled={enabled}>{value}</Name>
</Content>
);
Expand Down
4 changes: 2 additions & 2 deletions airbyte-webapp/src/packages/cloud/views/credits/CreditsPage/components/ConnectionCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ const ConnectionCell: React.FC<ConnectionCellProps> = ({
return (
<>
<Connector>
<Icon small icon={sourceIcon} />
<Icon icon={sourceIcon} />
{sourceDefinitionName}
</Connector>
<Connector>
<Arrow icon={faArrowRight} />
<Icon small icon={destinationIcon} />
<Icon icon={destinationIcon} />
{destinationDefinitionName}
</Connector>
</>
Expand Down