Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run some DATs as part of base-normalization tests #14312

Merged
merged 8 commits into from
Jul 1, 2022
Merged

Run some DATs as part of base-normalization tests #14312

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
430757a
run some destination tests as part of normalization tests
edgao Jun 30, 2022
5569371
ci creds
edgao Jun 30, 2022
f64460b
correct connector name
edgao Jun 30, 2022
c8dcd99
bash is hard
edgao Jul 1, 2022
0e6e60e
[test] unconditional fetch
edgao Jul 1, 2022
8a4835a
wut
edgao Jul 1, 2022
dc1fc4a
revert to conditional; remove logs
edgao Jul 1, 2022
04fdf00
syntax?
edgao Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/build-connector-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,12 @@ jobs:
run: |
source venv/bin/activate
ci_credentials ${{ github.event.inputs.connector }}
# normalization also runs destination-specific tests, so fetch their creds also
if test 'bases/base-normalization' '=' ${{ github.event.inputs.connector }}; then
ci_credentials destination-bigquery
ci_credentials destination-postgres
ci_credentials destination-snowflake
fi
env:
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
# TODO: seems like this should run in post-merge workflow
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/publish-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,12 @@ jobs:
run: |
source venv/bin/activate
ci_credentials ${{ matrix.connector }}
# normalization also runs destination-specific tests, so fetch their creds also
if test 'bases/base-normalization' '=' ${{ matrix.connector }}; then
ci_credentials destination-bigquery
ci_credentials destination-postgres
ci_credentials destination-snowflake
fi
env:
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
- name: Set Name and Version Environment Vars
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/test-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ jobs:
run: |
source venv/bin/activate
ci_credentials ${{ github.event.inputs.connector }}
# normalization also runs destination-specific tests, so fetch their creds also
if test 'bases/base-normalization' '=' ${{ matrix.connector }}; then
ci_credentials destination-bigquery
ci_credentials destination-postgres
ci_credentials destination-snowflake
fi
env:
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}

Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/test-performance-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,12 @@ jobs:
run: |
source venv/bin/activate
ci_credentials ${{ github.event.inputs.connector }}
# normalization also runs destination-specific tests, so fetch their creds also
if test 'bases/base-normalization' '=' ${{ github.event.inputs.connector }}; then
ci_credentials destination-bigquery
ci_credentials destination-postgres
ci_credentials destination-snowflake
fi
env:
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
- run: |
Expand Down
8 changes: 8 additions & 0 deletions airbyte-integrations/bases/base-normalization/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,14 @@ task("customIntegrationTestPython", type: PythonTask, dependsOn: installTestReqs
dependsOn ':airbyte-integrations:connectors:destination-clickhouse:airbyteDocker'
}

// DATs have some additional tests that exercise normalization code paths,
// so we want to run these in addition to the base-normalization integration tests.
// If you add more items here, make sure to also to have CI fetch their credentials.
// See git history for an example.
integrationTest.dependsOn(":airbyte-integrations:connectors:destination-bigquery:integrationTest")
integrationTest.dependsOn(":airbyte-integrations:connectors:destination-postgres:integrationTest")
integrationTest.dependsOn(":airbyte-integrations:connectors:destination-snowflake:integrationTest")

integrationTest.dependsOn("customIntegrationTestPython")
customIntegrationTests.dependsOn("customIntegrationTestPython")

Expand Down