🪟🐛 Keep refetching debug infos while job is running #14341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
teallarson
reviewed
Jul 6, 2022
| const lastAttemptEndTimestamp = data?.attempts[data.attempts.length - 1].attempt.endedAt; | ||
| // While no attempt ended timestamp exists yet (i.e. the job is still running) or it hasn't ended | ||
| // more than 2 minutes (2 * 60 * 1000ms) ago, keep refetching | ||
| return lastAttemptEndTimestamp && Date.now() - lastAttemptEndTimestamp * 1000 > 2 * 60 * 1000 ? false : 2500; |
There was a problem hiding this comment.
The PR description says 6 minutes, but this looks like 2. Is one of them incorrect?
There was a problem hiding this comment.
Sorry, forgot to update that :) I created this originally with 6 minutes, but Davin clarified for me, that the log is supposed to be max 1 minute late based on how our log fetching implementation worked, so I felt 2 minutes might be a long enough grace period to make sure. Updated the PR description now as well.
teallarson
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #14244
Before changing the querying infrastructure we used the logs from the
useGetJobcall which auto refreshed after 2.5 seconds. Since the switch to the auto generated client, we useget_debug_infofor the logs (since theuseGetJobreturns different types). This call wasn't auto refreshing so far.This PR now makes this call to auto refresh while the job it's fetching debug infos for hasn't been finished less than 2 minutes ago. We need some buffer time, since logs come in for some time even after the job is marked as done.