-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving docusaurus sidebar generation (#1927) #14369
Improving docusaurus sidebar generation (#1927) #14369
Conversation
Small update re changes introduced in this PR:
|
The Careers and open positions folder is no longer a part of docs and shouldn't show up in the sidebar |
Thank you!! |
@Mykyta-Serbynevskyi we now have broken links when I try to build. I would guess this is from killing that folder but I didn't look super hard
|
Hi @supertopher
I can suggest the following:
Let me know if it helps. |
@Mykyta-Serbynevskyi I cloned a fresh copy and that worked, though I found that confusing. |
I don't think this is a dealbreaker, but I'd like to hear from @Amruta-Ranade. @Mykyta-Serbynevskyi performed the work as requested: namely he built an exact copy of the OSS docs sidebar. It appears some links aren't navigable from the sidebar though (in OSS prod or in the PR). ie http://localhost:3000/operator-guides/configuring-airbyte/ Furthermore I think it's okay to ask docs to address these when we see them, but again I'd like to hear from Amruta on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @supertopher |
This seems to have broken connectors build
|
This PR improves automatic generation of docs sidebar via
docusaurus
tool.At the moment sidebar generated via
docusaurus
matches sidebar from docs.airbyte.comThings left to be done:
docusaurus
e.g "CLI documentation" in docs.airbyte.com