Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Craco integration + fix CSS order issue #14394

Merged
merged 6 commits into from
Jul 7, 2022
Merged

🪟 🔧 Craco integration + fix CSS order issue #14394

merged 6 commits into from
Jul 7, 2022

Conversation

dizel852
Copy link
Contributor

@dizel852 dizel852 commented Jul 4, 2022 •
edited
Loading

What

croco tool for tweaking webpack config

How

  • Add craco and config to tweak our webpack config flexibly
  • Fixed CSS order warning during CI build run
  • Also unblocks the 13550 PR

@dizel852
Changes:
46ae53a 
- add craco(latest stable) package;
- add mini-css-extract-plugin package
@dizel852
reset transformIgnorePatterns jest settings
81b2170
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Jul 4, 2022
@dizel852 dizel852 marked this pull request as ready for review July 5, 2022 13:30
@dizel852 dizel852 requested a review from a team as a code owner July 5, 2022 13:30
teallarson
teallarson approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the right call given the rewired approach did not work out and craco is in fact maintained again. Someone else may have stronger opinions on this though!

@dizel852 dizel852 requested a review from timroes July 7, 2022 20:20
@dizel852 dizel852 merged commit 3830e6a into master Jul 7, 2022
@dizel852 dizel852 deleted the vlad/craco-integration branch July 7, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teallarson teallarson teallarson approved these changes

@timroes timroes Awaiting requested review from timroes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dizel852 @teallarson