-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Amazon S3: Fix docs link issue #14397
Conversation
@lazebnyi Couple of Qs:
|
|
Thanks for the clarification on this - wasn't aware. The problem I was trying to tackle here is that we've come across users who type 'Amazon' expecting to surface 'S3'. I imagine that we'll start seeing folks type 'Minio' and not be able to find anything either. This would apply for both the source and destination. So the ideal situation here seems to be that the display name stays as 'S3' but we have some way of allowing search terms to surface this connector and those search terms being 'Amazon' and 'Minio'. What would it take for us to introduce this? cc: @sherifnada |
@misteryeo we need to add some notion of search terms to connectors. This is an OSS platform + Frontend change |
@Phlair Reverted name to S3. Plz review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What
Fix link in docs
How
Fix name of section in docs
Pre-merge Checklist
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here