Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Monday: timeout errors #14443

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Source Monday: timeout errors #14443

merged 4 commits into from
Jul 8, 2022

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Jul 6, 2022 •
edited
Loading

What

This is a problem specific to Items stream, as it has additional rate limits
https://github.com/airbytehq/alpha-beta-issues/issues/61

How

Added limit parameter, increased retry_factor

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 6, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented Jul 6, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-monday

🕑 connectors/source-monday https://github.com/airbytehq/airbyte/actions/runs/2622226552
❌ connectors/source-monday https://github.com/airbytehq/airbyte/actions/runs/2622226552
🐛 https://gradle.com/s/vt5d4nfjrkeae

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_oneof_usage[inputs0] - AssertionError: Th...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: All ...
FAILED test_core.py::TestBasicRead::test_read[inputs1] - AssertionError: All ...
FAILED test_core.py::TestBasicRead::test_read[inputs2] - AssertionError: All ...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 4 failed, 36 passed, 1 skipped in 563.36s (0:09:23) ==============

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jul 6, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-monday

🕑 connectors/source-monday https://github.com/airbytehq/airbyte/actions/runs/2622658485
✅ connectors/source-monday https://github.com/airbytehq/airbyte/actions/runs/2622658485
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                        Stmts   Miss  Cover
-----------------------------------------------
source_monday/__init__.py       2      0   100%
source_monday/source.py       102     46    55%
-----------------------------------------------
TOTAL                         104     46    56%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 40 passed, 1 skipped in 566.66s (0:09:26) ===================

lazebnyi
lazebnyi reviewed Jul 7, 2022
View reviewed changes
airbyte-integrations/connectors/source-monday/source_monday/spec.json
@@ -31,8 +31,6 @@
"auth_type": {
"type": "string",
"const": "oauth2.0",
"enum": ["oauth2.0"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have the potential to break existing connections because of the spec change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it shouldn't break anything as we have a SAT asserting enum and default keywords are not used in oneOf structures

midavadim
midavadim reviewed Jul 7, 2022
View reviewed changes
airbyte-integrations/connectors/source-monday/source_monday/source.py
@property
def retry_factor(self) -> int:
# this stream has additional rate limits, please see https://api.developer.monday.com/docs/items-queries#additional-rate-limit
return 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably I need an explanation why 30, because docs says that limit is "1 time every 2 minutes.".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, but according to logs, from time to time the API allows us to make requests once in about 30 to 90 seconds.. that's weird but that's the fact, so I decided to set the retry_factor to a minimum value

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this wont work, I'll increase it

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jul 8, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-monday

🕑 Publishing the following connectors:
connectors/source-monday
https://github.com/airbytehq/airbyte/actions/runs/2634427609


Connector Did it publish? Were definitions generated?
connectors/source-monday ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets July 8, 2022 07:20 Inactive
@davydov-d davydov-d merged commit fde2068 into master Jul 8, 2022
@davydov-d davydov-d deleted the ddavydov/#61-alpha-beta-source-monday-timeout-errors branch July 8, 2022 07:56
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 13, 2022
Merged
@ktstowell ktstowell mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midavadim midavadim midavadim left review comments

@lazebnyi lazebnyi lazebnyi left review comments

@bazarnov bazarnov bazarnov approved these changes

@Phlair Phlair Awaiting requested review from Phlair

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/monday
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davydov-d @midavadim @bazarnov @lazebnyi @octavia-squidington-iii