-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Monday: timeout errors #14443
Source Monday: timeout errors #14443
Conversation
/test connector=connectors/source-monday
Build FailedTest summary info:
|
/test connector=connectors/source-monday
Build PassedTest summary info:
|
@@ -31,8 +31,6 @@ | |||
"auth_type": { | |||
"type": "string", | |||
"const": "oauth2.0", | |||
"enum": ["oauth2.0"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have the potential to break existing connections because of the spec change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it shouldn't break anything as we have a SAT asserting enum
and default
keywords are not used in oneOf
structures
@property | ||
def retry_factor(self) -> int: | ||
# this stream has additional rate limits, please see https://api.developer.monday.com/docs/items-queries#additional-rate-limit | ||
return 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably I need an explanation why 30, because docs says that limit is "1 time every 2 minutes.".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, but according to logs, from time to time the API allows us to make requests once in about 30 to 90 seconds.. that's weird but that's the fact, so I decided to set the retry_factor
to a minimum value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this wont work, I'll increase it
/publish connector=connectors/source-monday
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
This is a problem specific to Items stream, as it has additional rate limits
https://github.com/airbytehq/alpha-beta-issues/issues/61
How
Added limit parameter, increased retry_factor