Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟🐛 Fixes connector status icon alignment #14465

Merged
merged 2 commits into from
Jul 8, 2022
Merged

🪟🐛 Fixes connector status icon alignment #14465

merged 2 commits into from
Jul 8, 2022

Conversation

natalyjazzviolin
Copy link
Contributor

What

Fixes #14260

How

Sets vertical-align of the icon value to bottom when the icon's status is inactive.

508E04C5-ADC6-48C9-B001-AD2EA6770064_4_5005_c
8B2B18CA-8450-4065-A9CA-D0E51F97A847_4_5005_c

@natalyjazzviolin natalyjazzviolin requested a review from a team as a code owner July 6, 2022 20:12
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Jul 6, 2022
edmundito
edmundito approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@edmundito edmundito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and updated the storybook to be able to set a value to the status icon for testing.

@natalyjazzviolin natalyjazzviolin merged commit 111ccce into master Jul 8, 2022
@natalyjazzviolin natalyjazzviolin deleted the icon-alignment branch July 8, 2022 17:00
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundito edmundito edmundito approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alignment off on connector status icon
2 participants
@natalyjazzviolin @edmundito