-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source File: add user-agent option #14488
🎉 Source File: add user-agent option #14488
Conversation
airbyte-integrations/connectors/source-file/source_file/client.py
Outdated
Show resolved
Hide resolved
@tim-werner were you able to build the connector locally and test the dev version? |
Yes I was able to build the connector locally and test the dev version. |
@marcosmarxm I have also updated the acceptance test to include the user_agent |
@marcosmarxm |
Thanks @tim-werner I'll test later today. |
/test connector=connectors/source-file
Build PassedTest summary info:
|
c665151
to
f72b3df
Compare
/publish connector=connectors/source-file
if you have connectors that successfully published but failed definition generation, follow step 4 here |
34bc6e9
to
4b83510
Compare
What
Fixes issue #14487 by adding an optional toggle to add an User-Agent to the request header
How
An optional user-agent header can be passed to the smart_open library in order to be able to fetch data from urls that are protected by cloudflare and that require a user-agent in the header
Recommended reading order
spec.json
🚨 User Impact 🚨
There should be no user impact
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.