Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Notion: fix normalization #14505

Merged
merged 7 commits into from
Jul 11, 2022

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Jul 7, 2022

What

Resolving: #8702

How

  • added utils.py module to handle nested properties transformation for pages, databases streams
  • edited schemas for pages, databases streams

🚨 User Impact 🚨

Users need to update the version and refresh schemas in order to pick-up latest schema changes.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Jul 7, 2022
@bazarnov bazarnov linked an issue Jul 7, 2022 that may be closed by this pull request
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 7, 2022
@bazarnov
Copy link
Collaborator Author

bazarnov commented Jul 7, 2022

/test connector=connectors/source-notion

🕑 connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/2631769261
✅ connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/2631769261
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                        Stmts   Miss  Cover
-----------------------------------------------
source_notion/__init__.py       2      0   100%
source_notion/streams.py      121      5    96%
source_notion/source.py        25      2    92%
source_notion/utils.py          9      4    56%
-----------------------------------------------
TOTAL                         157     11    93%

Build Passed

Test summary info:

All Passed

Copy link
Collaborator

@davydov-d davydov-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please provide an example of how the current version provokes the normalization to break?
are the schema changes a part of the fix? or is the fix encapsulated just within the python code?

@bazarnov
Copy link
Collaborator Author

bazarnov commented Jul 11, 2022

/publish connector=connectors/source-notion

🕑 Publishing the following connectors:
connectors/source-notion
https://github.com/airbytehq/airbyte/actions/runs/2649414020


Connector Did it publish? Were definitions generated?
connectors/source-notion

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov merged commit 7221842 into master Jul 11, 2022
@bazarnov bazarnov deleted the bazarnov/8702-source-notion-fix-normalization branch July 11, 2022 12:23
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets July 11, 2022 12:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/notion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Source Notion : Basic Normalization Fails
4 participants