🐛 Source Amazon Ads: Fix SAT test fails - need more expect_records #14533

grubberr · 2022-07-08T11:34:07Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Account data changed - update SAT tests

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-07-08T11:35:06Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2635818809
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2635818809
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          19      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  76      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          199      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               633      8    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 24 passed, 1 skipped in 1548.16s (0:25:48) ==================

This reverts commit aea61c4.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-07-08T14:06:31Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2636604013
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2636604013
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          19      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  76      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          199      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               633      8    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 21 passed, 1 skipped in 1294.25s (0:21:34) ==================

grubberr · 2022-07-11T07:32:10Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2647975765
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2647975765
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          19      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  76      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          199      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               633      8    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 21 passed, 1 skipped in 1158.36s (0:19:18) ==================

Fix SAT

aea61c4

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr linked an issue Jul 8, 2022 that may be closed by this pull request

🐛 Source Amazon Ads: Fix SAT test fails - need more expect_records #14532

Closed

grubberr self-assigned this Jul 8, 2022

github-actions bot added the area/connectors Connector related issues label Jul 8, 2022

octavia-squidington-iii added the connectors/source/amazon-ads label Jul 8, 2022

Merge branch 'master' into grubberr/14532-source-amazon-ads

45fb032

grubberr requested review from lazebnyi and midavadim July 8, 2022 12:43

grubberr added 2 commits July 8, 2022 17:05

Revert "Fix SAT"

972d31a

This reverts commit aea61c4.

expected_records.txt updated only

59ef8df

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

davydov-d approved these changes Jul 11, 2022

View reviewed changes

Merge branch 'master' into grubberr/14532-source-amazon-ads

478e797

grubberr merged commit 94e3e0e into master Jul 11, 2022

grubberr deleted the grubberr/14532-source-amazon-ads branch July 11, 2022 08:05

lazebnyi removed their request for review July 12, 2022 11:15

octavia-squidington-iii mentioned this pull request Jul 13, 2022

Bump Airbyte version from 0.39.35-alpha to 0.39.36-alpha #14690

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Amazon Ads: Fix SAT test fails - need more expect_records #14533

🐛 Source Amazon Ads: Fix SAT test fails - need more expect_records #14533

grubberr commented Jul 8, 2022 •

edited

Loading

grubberr commented Jul 8, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 8, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 11, 2022 •

edited by github-actions bot

Loading

🐛 Source Amazon Ads: Fix SAT test fails - need more expect_records #14533

🐛 Source Amazon Ads: Fix SAT test fails - need more expect_records #14533

Conversation

grubberr commented Jul 8, 2022 • edited Loading

What

grubberr commented Jul 8, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Jul 8, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Jul 11, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Jul 8, 2022 •

edited

Loading

grubberr commented Jul 8, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 8, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 11, 2022 •

edited by github-actions bot

Loading