Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple update to add a lookback_window to the datetime stream slicer #14609

Merged
merged 2 commits into from
Jul 12, 2022
Merged

simple update to add a lookback_window to the datetime stream slicer #14609

merged 2 commits into from
Jul 12, 2022

Conversation

brianjlai
Copy link
Contributor

What

Adds a lookback_window to the datetime stream slicer so that we can accommodate connectors that pull records with a buffer on the start/cursor date.

How

Just adds a new field to existing components. Pretty straightforward

Recommended reading order

  1. datetime_stream_slicer.py

@brianjlai brianjlai requested a review from girarda July 12, 2022 02:39
@brianjlai brianjlai requested a review from a team as a code owner July 12, 2022 02:39
@github-actions github-actions bot added the CDK Connector Development Kit label Jul 12, 2022
@brianjlai brianjlai merged commit cf71ccb into master Jul 12, 2022
@brianjlai brianjlai deleted the brian/declarative_lookback branch July 12, 2022 23:49
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianjlai @girarda