Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additionalProperties: false from JDBC destination connectors #14618

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
- name: Databricks Lakehouse
destinationDefinitionId: 072d5540-f236-4294-ba7c-ade8fd918496
dockerRepository: airbyte/destination-databricks
dockerImageTag: 0.2.3
dockerImageTag: 0.2.4
documentationUrl: https://docs.airbyte.io/integrations/destinations/databricks
icon: databricks.svg
releaseStage: alpha
Expand Down Expand Up @@ -168,7 +168,7 @@
- name: MS SQL Server
destinationDefinitionId: d4353156-9217-4cad-8dd7-c108fd4f74cf
dockerRepository: airbyte/destination-mssql
dockerImageTag: 0.1.19
dockerImageTag: 0.1.20
documentationUrl: https://docs.airbyte.io/integrations/destinations/mssql
icon: mssql.svg
releaseStage: alpha
Expand Down Expand Up @@ -270,7 +270,7 @@
- name: Snowflake
destinationDefinitionId: 424892c4-daac-4491-b35d-c6688ba547ba
dockerRepository: airbyte/destination-snowflake
dockerImageTag: 0.4.31
dockerImageTag: 0.4.32
documentationUrl: https://docs.airbyte.io/integrations/destinations/snowflake
icon: snowflake.svg
resourceRequirements:
Expand Down
18 changes: 3 additions & 15 deletions airbyte-config/init/src/main/resources/seed/destination_specs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@
- "overwrite"
- "append"
- "append_dedup"
- dockerImage: "airbyte/destination-databricks:0.2.3"
- dockerImage: "airbyte/destination-databricks:0.2.4"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/destinations/databricks"
connectionSpecification:
Expand All @@ -979,7 +979,6 @@
- "databricks_http_path"
- "databricks_personal_access_token"
- "data_source"
additionalProperties: false
properties:
accept_terms:
title: "Agree to the Databricks JDBC Driver Terms & Conditions"
Expand Down Expand Up @@ -2501,7 +2500,7 @@
supportsDBT: false
supported_destination_sync_modes:
- "append"
- dockerImage: "airbyte/destination-mssql:0.1.19"
- dockerImage: "airbyte/destination-mssql:0.1.20"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/destinations/mssql"
connectionSpecification:
Expand All @@ -2514,7 +2513,6 @@
- "username"
- "database"
- "schema"
additionalProperties: true
properties:
host:
title: "Host"
Expand Down Expand Up @@ -2572,7 +2570,6 @@
order: 7
oneOf:
- title: "Unencrypted"
additionalProperties: false
description: "The data transfer will not be encrypted."
required:
- "ssl_method"
Expand All @@ -2585,7 +2582,6 @@
- "unencrypted"
default: "unencrypted"
- title: "Encrypted (trust server certificate)"
additionalProperties: false
description: "Use the certificate provided by the server without verification.\
\ (For testing purposes only!)"
required:
Expand All @@ -2599,7 +2595,6 @@
- "encrypted_trust_server_certificate"
default: "encrypted_trust_server_certificate"
- title: "Encrypted (verify certificate)"
additionalProperties: false
description: "Verify and use the certificate provided by the server."
required:
- "ssl_method"
Expand Down Expand Up @@ -4369,7 +4364,7 @@
supported_destination_sync_modes:
- "overwrite"
- "append"
- dockerImage: "airbyte/destination-snowflake:0.4.31"
- dockerImage: "airbyte/destination-snowflake:0.4.32"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/destinations/snowflake"
connectionSpecification:
Expand Down Expand Up @@ -4511,7 +4506,6 @@
- "Standard"
default: "Standard"
- title: "[Recommended] Internal Staging"
additionalProperties: false
description: "Recommended for large production workloads for better speed\
\ and scalability."
required:
Expand All @@ -4525,7 +4519,6 @@
- "Internal Staging"
default: "Internal Staging"
- title: "AWS S3 Staging"
additionalProperties: false
description: "Recommended for large production workloads for better speed\
\ and scalability."
required:
Expand Down Expand Up @@ -4643,7 +4636,6 @@
\ key for each sync."
airbyte_secret: true
- title: "Google Cloud Storage Staging"
additionalProperties: false
description: "Recommended for large production workloads for better speed\
\ and scalability."
required:
Expand Down Expand Up @@ -4686,7 +4678,6 @@
multiline: true
order: 3
- title: "Azure Blob Storage Staging"
additionalProperties: false
description: "Recommended for large production workloads for better speed\
\ and scalability."
required:
Expand Down Expand Up @@ -4761,7 +4752,6 @@
- "host"
complete_oauth_output_specification:
type: "object"
additionalProperties: false
properties:
access_token:
type: "string"
Expand All @@ -4775,15 +4765,13 @@
- "refresh_token"
complete_oauth_server_input_specification:
type: "object"
additionalProperties: false
properties:
client_id:
type: "string"
client_secret:
type: "string"
complete_oauth_server_output_specification:
type: "object"
additionalProperties: false
properties:
client_id:
type: "string"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION destination-databricks

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.2.3
LABEL io.airbyte.version=0.2.4
LABEL io.airbyte.name=airbyte/destination-databricks
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"databricks_personal_access_token",
"data_source"
],
"additionalProperties": false,
"properties": {
"accept_terms": {
"title": "Agree to the Databricks JDBC Driver Terms & Conditions",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION destination-mssql-strict-encrypt

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.1.9
LABEL io.airbyte.version=0.1.10
LABEL io.airbyte.name=airbyte/destination-mssql-strict-encrypt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"title": "MS SQL Server Destination Spec",
"type": "object",
"required": ["host", "port", "username", "database", "schema"],
"additionalProperties": true,
"properties": {
"host": {
"title": "Host",
Expand Down Expand Up @@ -68,7 +67,6 @@
"oneOf": [
{
"title": "Encrypted (trust server certificate)",
"additionalProperties": false,
"description": "Use the certificate provided by the server without verification. (For testing purposes only!)",
"required": ["ssl_method"],
"type": "object",
Expand All @@ -83,7 +81,6 @@
},
{
"title": "Encrypted (verify certificate)",
"additionalProperties": false,
"description": "Verify and use the certificate provided by the server.",
"required": ["ssl_method", "trustStoreName", "trustStorePassword"],
"type": "object",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION destination-mssql

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.1.19
LABEL io.airbyte.version=0.1.20
LABEL io.airbyte.name=airbyte/destination-mssql
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"title": "MS SQL Server Destination Spec",
"type": "object",
"required": ["host", "port", "username", "database", "schema"],
"additionalProperties": true,
"properties": {
"host": {
"title": "Host",
Expand Down Expand Up @@ -68,7 +67,6 @@
"oneOf": [
{
"title": "Unencrypted",
"additionalProperties": false,
"description": "The data transfer will not be encrypted.",
"required": ["ssl_method"],
"type": "object",
Expand All @@ -83,7 +81,6 @@
},
{
"title": "Encrypted (trust server certificate)",
"additionalProperties": false,
"description": "Use the certificate provided by the server without verification. (For testing purposes only!)",
"required": ["ssl_method"],
"type": "object",
Expand All @@ -98,7 +95,6 @@
},
{
"title": "Encrypted (verify certificate)",
"additionalProperties": false,
"description": "Verify and use the certificate provided by the server.",
"required": ["ssl_method", "trustStoreName", "trustStorePassword"],
"type": "object",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION destination-oracle-strict-encrypt

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.1.5
LABEL io.airbyte.version=0.1.7
LABEL io.airbyte.name=airbyte/destination-oracle-strict-encrypt
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION destination-oracle

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.1.16
LABEL io.airbyte.version=0.1.18
LABEL io.airbyte.name=airbyte/destination-oracle
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
"oneOf": [
{
"title": "Unencrypted",
"additionalProperties": false,
"description": "Data transfer will not be encrypted.",
"required": ["encryption_method"],
"properties": {
Expand All @@ -76,7 +75,6 @@
},
{
"title": "Native Network Encryption (NNE)",
"additionalProperties": false,
"description": "The native network encryption gives you the ability to encrypt database connections, without the configuration overhead of TCP/IP and SSL/TLS and without the need to open and listen on different ports.",
"required": ["encryption_method"],
"properties": {
Expand All @@ -97,7 +95,6 @@
},
{
"title": "TLS Encrypted (verify certificate)",
"additionalProperties": false,
"description": "Verify and use the certificate provided by the server.",
"required": ["encryption_method", "ssl_certificate"],
"properties": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ RUN tar xf ${APPLICATION}.tar --strip-components=1

ENV ENABLE_SENTRY true

LABEL io.airbyte.version=0.4.31
LABEL io.airbyte.version=0.4.32
LABEL io.airbyte.name=airbyte/destination-snowflake
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@
},
{
"title": "[Recommended] Internal Staging",
"additionalProperties": false,
"description": "Recommended for large production workloads for better speed and scalability.",
"required": ["method"],
"properties": {
Expand All @@ -161,7 +160,6 @@
},
{
"title": "AWS S3 Staging",
"additionalProperties": false,
"description": "Recommended for large production workloads for better speed and scalability.",
"required": [
"method",
Expand Down Expand Up @@ -286,7 +284,6 @@
},
{
"title": "Google Cloud Storage Staging",
"additionalProperties": false,
"description": "Recommended for large production workloads for better speed and scalability.",
"required": [
"method",
Expand Down Expand Up @@ -329,7 +326,6 @@
},
{
"title": "Azure Blob Storage Staging",
"additionalProperties": false,
"description": "Recommended for large production workloads for better speed and scalability.",
"required": [
"method",
Expand Down Expand Up @@ -400,7 +396,6 @@
},
"complete_oauth_output_specification": {
"type": "object",
"additionalProperties": false,
"properties": {
"access_token": {
"type": "string",
Expand All @@ -414,7 +409,6 @@
},
"complete_oauth_server_input_specification": {
"type": "object",
"additionalProperties": false,
"properties": {
"client_id": {
"type": "string"
Expand All @@ -426,7 +420,6 @@
},
"complete_oauth_server_output_specification": {
"type": "object",
"additionalProperties": false,
"properties": {
"client_id": {
"type": "string",
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/databricks.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ Under the hood, an Airbyte data stream in Json schema is first converted to an A

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.2.4 | 2022-07-14 | [\#14618](https://github.com/airbytehq/airbyte/pull/14618) | Removed additionalProperties: false from JDBC destination connectors |
| 0.2.3 | 2022-06-16 | [\#13852](https://github.com/airbytehq/airbyte/pull/13852) | Updated stacktrace format for any trace message errors |
| 0.2.2 | 2022-06-13 | [\#13722](https://github.com/airbytehq/airbyte/pull/13722) | Rename to "Databricks Lakehouse". |
| 0.2.1 | 2022-06-08 | [\#13630](https://github.com/airbytehq/airbyte/pull/13630) | Rename to "Databricks Delta Lake" and add field orders in the spec. |
Expand Down
4 changes: 3 additions & 1 deletion docs/integrations/destinations/mssql.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ Using this feature requires additional configuration, when creating the source.

| Version | Date | Pull Request | Subject |
|:--------| :--- |:---------------------------------------------------------|:----------------------------------------------------------------------------------------------------|
| 0.1.20 | 2022-07-14 | [\#14618](https://github.com/airbytehq/airbyte/pull/14618) | Removed additionalProperties: false from JDBC destination connectors |
| 0.1.19 | 2022-05-25 | [13054](https://github.com/airbytehq/airbyte/pull/13054) | Destination MSSQL: added custom JDBC parameters support. |
| 0.1.18 | 2022-05-17 | [12820](https://github.com/airbytehq/airbyte/pull/12820) | Improved 'check' operation performance |
| 0.1.17 | 2022-04-05 | [11729](https://github.com/airbytehq/airbyte/pull/11729) | Bump mina-sshd from 2.7.0 to 2.8.0 |
Expand All @@ -138,7 +139,8 @@ Using this feature requires additional configuration, when creating the source.

| Version | Date | Pull Request | Subject |
|:--------| :--- | :--- | :--- |
| 0.1.9 | 2022-06-17 | [13864](https://github.com/airbytehq/airbyte/pull/13864) | Updated stacktrace format for any trace message errors |
| 0.1.10 | 2022-07-14 | [\#14618](https://github.com/airbytehq/airbyte/pull/14618) | Removed additionalProperties: false from JDBC destination connectors |
| 0.1.9 | 2022-06-17 | [13864](https://github.com/airbytehq/airbyte/pull/13864) | Updated stacktrace format for any trace message errors |
| 0.1.8 | 2022-05-25 | [13054](https://github.com/airbytehq/airbyte/pull/13054) | Destination MSSQL: added custom JDBC parameters support. |
| 0.1.6 | 2022-05-17 | [12820](https://github.com/airbytehq/airbyte/pull/12820) | Improved 'check' operation performance |
| 0.1.5 | 2022-02-25 | [10421](https://github.com/airbytehq/airbyte/pull/10421) | Refactor JDBC parameters handling |
Expand Down
4 changes: 3 additions & 1 deletion docs/integrations/destinations/oracle.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ Airbite has the ability to connect to the Oracle source with 3 network connectiv

| Version | Date | Pull Request | Subject |
|:--------| :--- |:---------------------------------------------------------|:----------------------------------------------------------------------------------------------------|
| 0.1.18 | 2022-07-14 | [\#14618](https://github.com/airbytehq/airbyte/pull/14618) | Removed additionalProperties: false from JDBC destination connectors |
| 0.1.17 | 2022-05-17 | [12820](https://github.com/airbytehq/airbyte/pull/12820) | Improved 'check' operation performance |
| 0.1.16 | 2022-04-06 | [11514](https://github.com/airbytehq/airbyte/pull/11514) | Bump mina-sshd from 2.7.0 to 2.8.0 |
| 0.1.15 | 2022-02-25 | [10421](https://github.com/airbytehq/airbyte/pull/10421) | Refactor JDBC parameters handling and remove DBT support |
Expand All @@ -112,7 +113,8 @@ Airbite has the ability to connect to the Oracle source with 3 network connectiv

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:--------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------------------|
| 0.1.5 | 2022-05-17 | [12820](https://github.com/airbytehq/airbyte/pull/12820) | Improved 'check' operation performance |
| 0.1.7 | 2022-07-14 | [\#14618](https://github.com/airbytehq/airbyte/pull/14618) | Removed additionalProperties: false from JDBC destination connectors |
| 0.1.5 | 2022-05-17 | [12820](https://github.com/airbytehq/airbyte/pull/12820) | Improved 'check' operation performance |
| 0.1.4 | 2022-02-25 | [10421](https://github.com/airbytehq/airbyte/pull/10421) | Refactor JDBC parameters handling and remove DBT support |
| 0.1.3 | 2022-02-14 | [10256](https://github.com/airbytehq/airbyte/pull/10256) | (unpublished) Add `-XX:+ExitOnOutOfMemoryError` JVM option |
| 0.1.2 | 2021-01-29 | [\#9177](https://github.com/airbytehq/airbyte/pull/9177) | Update connector fields title/description |
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/snowflake.md
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ Now that you have set up the Snowflake destination connector, check out the foll

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:-----------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------------------------------------------|
| 0.4.32 | 2022-07-14 | [\#14618](https://github.com/airbytehq/airbyte/pull/14618) | Removed additionalProperties: false from JDBC destination connectors |
| 0.4.31 | 2022-07-07 | [\#13729](https://github.com/airbytehq/airbyte/pull/13729) | Improve configuration field description |
| 0.4.30 | 2022-06-24 | [\#14114](https://github.com/airbytehq/airbyte/pull/14114) | Remove "additionalProperties": false from specs for connectors with staging |
| 0.4.29 | 2022-06-17 | [\#13753](https://github.com/airbytehq/airbyte/pull/13753) | Deprecate and remove PART_SIZE_MB fields from connectors based on StreamTransferManager |
Expand Down