Added _id and _cid to the schema for generated streams #14647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-marquardt
changed the title
alexander-marquardt
changed the title
sherifnada
approved these changes
Jul 13, 2022
|
@alexander-marquardt shouldn't we publish a new version of the connector as part of this? |
|
Oh, probably - what are the steps for that? I assumed that it would automagically happen .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This connector automatically populates the json schema, however the schema that is pulled back from Webflow does not include the
_id(record id) or the_cid(collection id) fields in the records that are returned. These are now manually added in after pulling the webflow schema back to Airbyte.How
These two fields are added into the dictionary returned by the
get_json_schemamethod insideCollectionContentsI have confirmed on my local version of Airbyte that these fields now appear in the catalog, as demonstrated in the image below: