Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13524 Resolved host port for mac os #14663

Merged
merged 2 commits into from
Jul 13, 2022
Merged

13524 Resolved host port for mac os #14663

merged 2 commits into from
Jul 13, 2022

Conversation

suhomud
Copy link
Contributor

@suhomud suhomud commented Jul 13, 2022 •
edited
Loading

What

  1. The connection refused issue for mac os
  2. Clickhouse docker image incompatibility with Mac M1

How

  1. Resolved host/port for mac os.
  2. The yandex/clickhouse-server image does not support arm architecture. Did update to clickhouse/clickhouse-server:22.5
  3. Testcontainer version 1.16.2 does not support clickhouse/clickhouse-server. Did update to 1.17.3

@suhomud suhomud requested a review from a team as a code owner July 13, 2022 08:02
@github-actions github-actions bot added the area/connectors Connector related issues label Jul 13, 2022
@suhomud
Copy link
Contributor Author

suhomud commented Jul 13, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2661923764
✅ connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2661923764
No Python unittests run

Build Passed

Test summary info:

All Passed

@suhomud
Copy link
Contributor Author

suhomud commented Jul 13, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2663012675
✅ connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2663012675
No Python unittests run

Build Passed

Test summary info:

All Passed

@suhomud suhomud linked an issue Jul 13, 2022 that may be closed by this pull request
Fix integration tests destination-clickhouse Mac OS #13524
Closed
@suhomud
Copy link
Contributor Author

suhomud commented Jul 13, 2022

Tests which was failing are passed on M1:
Screenshot 2022-07-13 at 18 18 10
Also fine for Mac Intel:
Screenshot 2022-07-13 at 18 19 11

@suhomud suhomud self-assigned this Jul 13, 2022
alexandr-shegeda
alexandr-shegeda approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suhomud suhomud merged commit 8abe9d9 into master Jul 13, 2022
@suhomud suhomud deleted the suhomud/13524_fix_integration_tests_destination-clickhouse_mac_os branch July 13, 2022 11:36
edgao
edgao reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao left review comments

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

Assignees

@suhomud suhomud

Labels
area/connectors Connector related issues connectors/destination/clickhouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix integration tests destination-clickhouse Mac OS
4 participants
@suhomud @edgao @alexandr-shegeda @octavia-squidington-iii