Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Chargebee: fix transactions sort-by #14672

Merged
merged 3 commits into from
Jul 13, 2022
Merged

🐛 Source Chargebee: fix transactions sort-by #14672

merged 3 commits into from
Jul 13, 2022

Conversation

mustangJaro
Copy link
Contributor

What

This works to resolve fetching transactions from Chargebee as noted here

How

The sort-by field that was previously declared, created-at, was not a field available on the transactions model in Chargebee. As documented here, the transactions model uses the date field

Recommended reading order

  1. streams.py

🚨 User Impact 🚨

Just positive user impacts! 😉

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit
  1. Run the setup / configuration steps
  2. After running python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json, ensure transaction data is output
  3. Run the unit tests
image

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Jul 13, 2022
@mustangJaro mustangJaro changed the title 🐛 Chargebee Transactions: fix sort-by 🐛 Source Chargebee: fix transactions sort-by Jul 13, 2022
@marcosmarxm
Copy link
Member

marcosmarxm commented Jul 13, 2022

/test connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/2664042546
✅ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/2664042546
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                Stmts   Miss  Cover
-------------------------------------------------------
source_chargebee/source.py             25      0   100%
source_chargebee/__init__.py            2      0   100%
source_chargebee/streams.py           159     27    83%
source_chargebee/rate_limiting.py      19      7    63%
-------------------------------------------------------
TOTAL                                 205     34    83%

Build Passed

Test summary info:

All Passed

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 13, 2022
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mustangJaro for this fix!

@alafanechere
Copy link
Contributor

alafanechere commented Jul 13, 2022

/publish connector=connectors/source-chargebee

🕑 Publishing the following connectors:
connectors/source-chargebee
https://github.com/airbytehq/airbyte/actions/runs/2664524487


Connector Did it publish? Were definitions generated?
connectors/source-chargebee

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@alafanechere alafanechere self-assigned this Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/chargebee
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants