Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13539 Fix integration tests source-clickhouse Mac OS #14701

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ private void startTestContainers() {
}

private void initAndStartJdbcContainer() {
db = (ClickHouseContainer) new ClickHouseContainer("yandex/clickhouse-server:21.8.8.29-alpine").withNetwork(network);
db = (ClickHouseContainer) new ClickHouseContainer("clickhouse/clickhouse-server:22.5").withNetwork(network);
db.start();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import io.airbyte.integrations.source.clickhouse.ClickHouseSource;
import io.airbyte.integrations.source.jdbc.AbstractJdbcSource;
import io.airbyte.integrations.source.jdbc.test.JdbcSourceAcceptanceTest;
import io.airbyte.integrations.util.HostPortResolver;
import java.sql.JDBCType;
import java.sql.SQLException;
import java.util.List;
Expand Down Expand Up @@ -81,8 +82,8 @@ public void setup() throws Exception {
db.start();

config = Jsons.jsonNode(ImmutableMap.builder()
.put("host", db.getHost())
.put("port", db.getFirstMappedPort())
.put("host", HostPortResolver.resolveHost(db))
.put("port", HostPortResolver.resolvePort(db))
.put("database", SCHEMA_NAME)
.put("username", db.getUsername())
.put("password", db.getPassword())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import io.airbyte.integrations.source.clickhouse.ClickHouseSource;
import io.airbyte.integrations.source.jdbc.AbstractJdbcSource;
import io.airbyte.integrations.source.jdbc.test.JdbcStressTest;
import io.airbyte.integrations.util.HostPortResolver;
import java.sql.JDBCType;
import java.util.Optional;
import org.junit.jupiter.api.AfterEach;
Expand All @@ -32,12 +33,12 @@ public Optional<String> getDefaultSchemaName() {
@Override
@BeforeEach
public void setup() throws Exception {
db = new ClickHouseContainer("yandex/clickhouse-server:21.8.8.29-alpine");
db = new ClickHouseContainer("clickhouse/clickhouse-server:22.5");
db.start();

config = Jsons.jsonNode(ImmutableMap.builder()
.put("host", db.getHost())
.put("port", db.getFirstMappedPort())
.put("host", HostPortResolver.resolveHost(db))
.put("port", HostPortResolver.resolvePort(db))
.put("database", SCHEMA_NAME)
.put("username", db.getUsername())
.put("password", db.getPassword())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ protected JsonNode getState() {

@Override
protected void setupEnvironment(final TestDestinationEnv environment) throws Exception {
db = new ClickHouseContainer("yandex/clickhouse-server:21.8.8.29-alpine");
db = new ClickHouseContainer("clickhouse/clickhouse-server:22.5");
db.start();

config = Jsons.jsonNode(ImmutableMap.builder()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import io.airbyte.integrations.source.clickhouse.ClickHouseSource;
import io.airbyte.integrations.source.jdbc.AbstractJdbcSource;
import io.airbyte.integrations.source.jdbc.test.JdbcSourceAcceptanceTest;
import io.airbyte.integrations.util.HostPortResolver;
import java.sql.JDBCType;
import java.util.List;
import javax.sql.DataSource;
Expand Down Expand Up @@ -68,8 +69,8 @@ static void init() {
@BeforeEach
public void setup() throws Exception {
final JsonNode configWithoutDbName = Jsons.jsonNode(ImmutableMap.builder()
.put("host", container.getHost())
.put("port", container.getFirstMappedPort())
.put("host", HostPortResolver.resolveHost(container))
.put("port", HostPortResolver.resolvePort(container))
.put("username", "default")
.put("password", "")
.build());
Expand Down
2 changes: 1 addition & 1 deletion deps.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ connectors-testcontainers-scylla = "1.16.2"
connectors-testcontainers-tidb = "1.16.3"
connectors-destination-testcontainers-clickhouse = "1.17.3"
connectors-destination-testcontainers-oracle-xe = "1.16.0"
connectors-source-testcontainers-clickhouse = "1.16.0"
connectors-source-testcontainers-clickhouse = "1.17.3"
platform-testcontainers = "1.17.1"

[libraries]
Expand Down