Bmoric/add non cdc partial reset acceptance test #14764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 164d7da05990268b09e315eb88ff297d3a9f52f4.
github-actions
bot
added
area/platform
…-non-cdc-partial-reset-acceptance-test
lmossman
reviewed
Jul 15, 2022
| @@ -388,7 +388,6 @@ public WebBackendConnectionRead webBackendUpdateConnectionNew(final WebBackendCo | |||
| final ConfiguredAirbyteCatalog existingConfiguredCatalog = | |||
| configRepository.getConfiguredCatalogForConnection(connectionId); | |||
| ConnectionRead connectionRead; | |||
| connectionRead = connectionsHandler.updateConnection(connectionUpdate); | |||
There was a problem hiding this comment.
I don't think this change is necessary - since we are capturing the existing configured catalog before we update the connection, it is fine to execute this call here
There was a problem hiding this comment.
reverted, I was wondering why the test were not passing it was not the root cause
…-non-cdc-partial-reset-acceptance-test
…-non-cdc-partial-reset-acceptance-test
github-actions
bot
removed
area/server
area/platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a new test that test the different updates operations.
How
This is adding a single test that will:
This is done in a single test in order to avoid running the initial sync multiple times.
It is also refactoring the common functions of
BasicAcceptanceTestandCdcAcceptanceTest