Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip running CI again when bumping connector version with /publish command #14771

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Jul 15, 2022

When a connector is published with the /publish command, upon success, the last thing the action does is commit back changes to the manifest files (like this, for example).

Since we shouldn't /publish until CI is green, and the side-effects of the publish command don't modify any code in the connector's directory, running CI again seems unnecessary. Waiting until this new batch of tests is complete slows down the publishing workflow.

This PR adds the magic phase [ci skip] to the git comment the bot adds to not run CI again after a successful /publish. Learn more here.

@evantahler evantahler marked this pull request as ready for review July 15, 2022 22:38
@evantahler evantahler changed the title Skip CI when bumping connector version with /publish command Skip running CI again when bumping connector version with /publish command Jul 15, 2022
Copy link
Contributor

@Phlair Phlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceeee! 👍

@evantahler evantahler temporarily deployed to more-secrets July 18, 2022 15:11 Inactive
@evantahler evantahler merged commit dd97278 into master Jul 18, 2022
@evantahler evantahler deleted the evan/ci-skip-publish branch July 18, 2022 15:13
@davinchia
Copy link
Contributor

Very cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants