Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align strict-encrypt connector version with the actual connector #14775

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

grishick
Copy link
Contributor

Change the version of destination-oracle-strict-encrypt to match the version of destination-oracle connector

Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, I always forget these variants exist.

I can't find the specifics, but didn't liren/davin make this process better during hackdays?

Copy link
Contributor

@ryankfu ryankfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we talked about this but currently the build process doesn't allow for multiple updates to the several Dockerfiles at once, right?

I remember this was my assignment from yesterday so that's my fault I dropped the ball. It's definitely a hassle to have to make multiple PRs when I can definitely see this as an auto generated from from the general database version or would that cause issues because it would be important to separate the versioning?

@grishick
Copy link
Contributor Author

ugh, I always forget these variants exist.

I can't find the specifics, but didn't liren/davin make this process better during hackdays?

I don't think their project is finished yet

@grishick
Copy link
Contributor Author

LGTM, we talked about this but currently the build process doesn't allow for multiple updates to the several Dockerfiles at once, right?

I remember this was my assignment from yesterday so that's my fault I dropped the ball. It's definitely a hassle to have to make multiple PRs when I can definitely see this as an auto generated from from the general database version or would that cause issues because it would be important to separate the versioning?

ultimately, we want to get rid of these "***-strict-encrypt" connectors in favor of a solution that @tuliren and @davinchia came up with during the last hackathon

@grishick
Copy link
Contributor Author

grishick commented Jul 18, 2022

/publish connector=destination-oracle-strict-encrypt run-tests=false

🕑 Publishing the following connectors:
destination-oracle-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/2693687196


Connector Did it publish? Were definitions generated?
destination-oracle-strict-encrypt

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grishick
Copy link
Contributor Author

grishick commented Jul 18, 2022

/publish connector=connectors/destination-oracle-strict-encrypt run-tests=false

🕑 Publishing the following connectors:
connectors/destination-oracle-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/2693855677


Connector Did it publish? Were definitions generated?
connectors/destination-oracle-strict-encrypt

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grishick grishick merged commit 6673dc4 into master Jul 18, 2022
@grishick grishick deleted the greg/oracle-strict-encrypt branch July 18, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants