Source Facebook marketing: check "MANAGE" task permission

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

@@ -248,7 +248,7 @@
 - name: Facebook Marketing
   sourceDefinitionId: e7778cfc-e97c-4458-9ecb-b4f2bba8946c
   dockerRepository: airbyte/source-facebook-marketing
-  dockerImageTag: 0.2.54
+  dockerImageTag: 0.2.55
   documentationUrl: https://docs.airbyte.io/integrations/sources/facebook-marketing
   icon: facebook.svg
   sourceType: api

airbyte-config/init/src/main/resources/seed/source_specs.yaml

@@ -1827,7 +1827,7 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-facebook-marketing:0.2.54"
+- dockerImage: "airbyte/source-facebook-marketing:0.2.55"
   spec:
     documentationUrl: "https://docs.airbyte.io/integrations/sources/facebook-marketing"
     changelogUrl: "https://docs.airbyte.io/integrations/sources/facebook-marketing"
@@ -2163,7 +2163,7 @@
           title: "Maximum size of Batched Requests"
           description: "Maximum batch size used when sending batch requests to Facebook\
             \ API. Most users do not need to set this field unless they specifically\
-            \ need to tune   the connector to address specific issues or use cases."
+            \ need to tune the connector to address specific issues or use cases."
           default: 50
           order: 9
           exclusiveMinimum: 0

airbyte-integrations/connectors/source-facebook-marketing/Dockerfile

@@ -13,5 +13,5 @@ ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
 
-LABEL io.airbyte.version=0.2.54
+LABEL io.airbyte.version=0.2.55
 LABEL io.airbyte.name=airbyte/source-facebook-marketing

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams/streams.py

@@ -4,14 +4,15 @@
 
 import base64
 import logging
-from typing import Any, Iterable, List, Mapping, Optional
+from typing import Any, Iterable, List, Mapping, Optional, Set
 
 import pendulum
 import requests
 from airbyte_cdk.models import SyncMode
 from cached_property import cached_property
 from facebook_business.adobjects.abstractobject import AbstractObject
 from facebook_business.adobjects.adaccount import AdAccount as FBAdAccount
+from facebook_business.adobjects.user import User
 
 from .base_insight_streams import AdsInsights
 from .base_streams import FBMarketingIncrementalStream, FBMarketingReversedIncrementalStream, FBMarketingStream
@@ -149,6 +150,27 @@ class AdAccount(FBMarketingStream):
     use_batch = False
     enable_deleted = False
 
+    def get_task_permissions(self) -> Set[str]:
+        """https://developers.facebook.com/docs/marketing-api/reference/ad-account/assigned_users/"""
+        res = set()
+        me = User(fbid="me", api=self._api.api)
+        for business_user in me.get_business_users():
+            assigned_users = self._api.account.get_assigned_users(params={"business": business_user["business"].get_id()})
+            for assigned_user in assigned_users:
+                if business_user.get_id() == assigned_user.get_id():
+                    res.update(set(assigned_user["tasks"]))
+        return res
+
+    @cached_property
+    def fields(self) -> List[str]:
+        properties = super().fields
+        # https://developers.facebook.com/docs/marketing-apis/guides/javascript-ads-dialog-for-payments/
+        # To access "funding_source_details", the user making the API call must have a MANAGE task permission for
+        # that specific ad account.
+        if "funding_source_details" in properties and "MANAGE" not in self.get_task_permissions():
+            properties.remove("funding_source_details")
+        return properties
+
     def list_objects(self, params: Mapping[str, Any]) -> Iterable:
         """noop in case of AdAccount"""
         return [FBAdAccount(self._api.account.get_id())]

airbyte-integrations/connectors/source-facebook-marketing/unit_tests/test_client.py

@@ -124,6 +124,7 @@ def test_common_error_retry(self, error_response, requests_mock, api, account_id
             },
         ]
 
+        requests_mock.register_uri("GET", FacebookSession.GRAPH + f"/{FB_API_VERSION}/me/business_users", json={"data": []})
         requests_mock.register_uri("GET", FacebookSession.GRAPH + f"/{FB_API_VERSION}/act_{account_id}/", responses)
         requests_mock.register_uri("GET", FacebookSession.GRAPH + f"/{FB_API_VERSION}/{account_data['id']}/", responses)
 

docs/integrations/sources/facebook-marketing.md

@@ -120,7 +120,8 @@ Please be informed that the connector uses the `lookback_window` parameter to pe
 
 | Version | Date       | Pull Request                                             | Subject                                                                                                                                                                                                                                                                                           |
 |:--------|:-----------|:---------------------------------------------------------|:--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| 0.2.54  | 2022-06-29 | [14267](https://github.com/airbytehq/airbyte/pull/14267) | Make MAX_BATCH_SIZE available in config |                     
+| 0.2.55  | 2022-07-18 | [14786](https://github.com/airbytehq/airbyte/pull/14786) | Check if the authorized user has the "MANAGE" task permission when getting the `funding_source_details` field in the ad\_account stream                                                                                                                                                            |
+| 0.2.54  | 2022-06-29 | [14267](https://github.com/airbytehq/airbyte/pull/14267) | Make MAX_BATCH_SIZE available in config                                                                                                                                                                                                                                                           |
 | 0.2.53  | 2022-06-16 | [13623](https://github.com/airbytehq/airbyte/pull/13623) | Add fields `bid_amount` `bid_strategy` `bid_constraints` to `ads_set` stream                                                                                                                                                                                                                      |
 | 0.2.52  | 2022-06-14 | [13749](https://github.com/airbytehq/airbyte/pull/13749) | Fix the `not syncing any data` issue                                                                                                                                                                                                                                                              |
 | 0.2.51  | 2022-05-30 | [13317](https://github.com/airbytehq/airbyte/pull/13317) | Change tax_id to string (Canadian has letter in tax_id)                                                                                                                                                                                                                                           |