-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalization for Snowflake destination: added support for key pair authentication #14792
Merged
sashaNeshcheret
merged 8 commits into
master
from
12255/normalization-for-key-pair-auth-for-snowflake
Jul 23, 2022
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7dce48c
Normalization for Snowflake destination: added support for key pair a…
sashaNeshcheret f02c29e
Normalization for Snowflake destination: updated changelogs
sashaNeshcheret 5893178
Normalization for Snowflake destination: renamed property passphrase …
sashaNeshcheret aa85fa4
Merge remote-tracking branch 'origin/master' into 12255/normalization…
sashaNeshcheret 49b888d
Normalization for Snowflake destination: bump normalization version i…
sashaNeshcheret 17172e1
Normalization for Snowflake destination: added unit tests and change …
sashaNeshcheret c8e300d
Normalization for Snowflake destination: added unit tests and change …
sashaNeshcheret faafb1b
Normalization for Snowflake destination: added unit tests and change …
sashaNeshcheret File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: prefer
with open()... as f
overopen()... close()
; this is basically equivalent to Java'stry (OutputStream s = ...)
:(then you don't need to
f.close()
at all)