-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉New Source: Zenefits #14809
🎉New Source: Zenefits #14809
Conversation
here's my email: yash.makwana@pliancy.com, do reach out to me for any questions. |
@harshithmullapudi could you review this and publish without the credentials for now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few comments, sorry the long delay to review it.
airbyte-integrations/connectors/source-zenefits/source_zenefits/schemas/TODO.md
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zenefits/source_zenefits/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zenefits/source_zenefits/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zenefits/source_zenefits/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zenefits/source_zenefits/source.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zenefits/source_zenefits/spec.json
Outdated
Show resolved
Hide resolved
@marcosmarxm I have made the necessary changes you suggested, the only thing with check_connection is I have a Bearer Token and I have to work surround that. |
Hey @makyash is it possible to give me access to push a commit over this repo. I have some fixes to make and a documentation to add. If not do you mind doing these
|
@harshithmullapudi let me know, if the changes were accurate or else I will give you the access to push a commit into this repo. |
Sure checking |
LGTM |
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
2. created a new file zenefits.md
897f586
to
82741a5
Compare
/publish connector=connectors/source-zenefits
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-zenefits run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* New Source: Zenefits * updated Readme.md * Update spec.json * Update request headers Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> * Update source.py * removed sample_files * 1. updated source_definition 2. created a new file zenefits.md * Delete TODO.md * fix: remove .class files * fix: added back source_definition * fix: rebase with origin master * fix: updated specs Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: Harshith Mullapudi <harshithmullapudi@gmail.com>
* New Source: Zenefits * updated Readme.md * Update spec.json * Update request headers Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> * Update source.py * removed sample_files * 1. updated source_definition 2. created a new file zenefits.md * Delete TODO.md * fix: remove .class files * fix: added back source_definition * fix: rebase with origin master * fix: updated specs Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: Harshith Mullapudi <harshithmullapudi@gmail.com>
What
Describe what the change is solving
Hello Team,
We at Pliancy, have created this python custom connector, that interacts with the API and pulls the data from the source. This connector helps in time tracking and is used by many companies like ours. Everything is explained properly on how to work this connector locally as well in the readme.md file.
It helps to add screenshots if it affects the frontend.
How
Describe the solution
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.