Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Intercom: added state_checkpoint_interval for all incremental streams #14830

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

bazarnov
Copy link
Collaborator

What

Resolving: https://github.com/airbytehq/oncall/issues/328

How

  • added state_checkpoint_interval for all incremental streams to emit state messages more frequently.

🚨 User Impact 🚨

No user impact.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 19, 2022
@bazarnov
Copy link
Collaborator Author

bazarnov commented Jul 19, 2022

/test connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/2697281609
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/2697281609
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              298    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  964    246    74%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_intercom/__init__.py       2      0   100%
source_intercom/utils.py         60      8    87%
source_intercom/source.py       256     42    84%
-------------------------------------------------
TOTAL                           318     50    84%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_intercom/__init__.py       2      0   100%
source_intercom/utils.py         60      1    98%
source_intercom/source.py       256     21    92%
-------------------------------------------------
TOTAL                           318     22    93%

Build Passed

Test summary info:

	 =========================== short test summary info ============================
	 SKIPPED [9] integration_tests/integration_test.py:33: need to refresh this test, it is very slow
	 �[33m============= �[32m2 passed�[0m, �[33m�[1m9 skipped�[0m, �[33m�[1m27 warnings�[0m�[33m in 68.77s (0:01:08)�[0m�[33m =============�[0m

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation looks good - can you confirm that this is safe to do given how the API works?

@bazarnov
Copy link
Collaborator Author

implementation looks good - can you confirm that this is safe to do given how the API works?

Great question! During the tests, the order and the final records count were checked, should be safe to do.

@bazarnov
Copy link
Collaborator Author

bazarnov commented Jul 20, 2022

/publish connector=connectors/source-intercom

🕑 Publishing the following connectors:
connectors/source-intercom
https://github.com/airbytehq/airbyte/actions/runs/2703513516


Connector Did it publish? Were definitions generated?
connectors/source-intercom

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov merged commit 6bf7064 into master Jul 20, 2022
@bazarnov bazarnov deleted the bazarnov/328-source-intercom-state-checkpoint branch July 20, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/intercom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants