-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Intercom: added state_checkpoint_interval
for all incremental streams
#14830
🐛 Source Intercom: added state_checkpoint_interval
for all incremental streams
#14830
Conversation
/test connector=connectors/source-intercom
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation looks good - can you confirm that this is safe to do given how the API works?
Great question! During the tests, the order and the final records count were checked, should be safe to do. |
/publish connector=connectors/source-intercom
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Resolving: https://github.com/airbytehq/oncall/issues/328
How
state_checkpoint_interval
for all incremental streams to emit state messages more frequently.🚨 User Impact 🚨
No user impact.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here