Move connection delete notice out of banner #14882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
teallarson
approved these changes
Jul 20, 2022
|
Talked offline: it's actually a (indeed weird) visual effect, but they are "perfectly" aligned in a flexbox with align-items: center. |
mfsiega-airbyte
pushed a commit
that referenced
this pull request
Jul 21, 2022
* Move connection delete notice out of banner * Add empty NL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This moves the "this connection has been deleted" into a infoBox instead of a banner on the page, so we don't have the collision of banners currently happening when the workspace is also out of credits (and in the future also for showing the trial ending date).