Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log stream_instance's metadata #15025

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Log stream_instance's metadata #15025

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae44ff4
Log stream_instance's metadata
girarda Jul 26, 2022
ab81284
Merge branch 'master' into alex/debug_stream_info
girarda Jul 26, 2022
30a7b05
syncmode is only set on ConfiguredStream
girarda Jul 26, 2022
c60f757
log both configured stream and stream instance
girarda Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions airbyte-cdk/python/airbyte_cdk/sources/abstract_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,15 +145,21 @@ def _read_stream(
if internal_config.page_size and isinstance(stream_instance, HttpStream):
logger.info(f"Setting page size for {stream_instance.name} to {internal_config.page_size}")
stream_instance.page_size = internal_config.page_size

logger.debug(
f"Syncing stream: {configured_stream.stream.name}",
f"Syncing configured stream: {configured_stream.stream.name}",
extra={
"sync_mode": configured_stream.sync_mode,
"primary_key": configured_stream.primary_key,
"cursor_field": configured_stream.cursor_field,
},
)
logger.debug(
f"Syncing stream instance: {stream_instance.name}",
extra={
"primary_key": stream_instance.primary_key,
"cursor_field": stream_instance.cursor_field,
},
)

use_incremental = configured_stream.sync_mode == SyncMode.incremental and stream_instance.supports_incremental
if use_incremental:
Expand Down