🪟 🐛 Connection Creation form should use existing values before using retreived values

[teallarson]

What

Closes #14844

Previously, when creating a Connection, if an item from outside the syncCatalog object was updated, when the form reinitialized, any user-configured values in the syncCatalog fields would be overwritten.

How

Now, we grab the syncCatalog from the formValues object if it exists, or else grab it from the value we got from the API.

Recommended reading order

There is only one file.

Testing

Create a new connection.
Change some of the items in the syncCatalog section (enable/disable streams, change their sync modes, etc.).
Change the value in a text input field at the top of the form.
Values on the form should not change (except for the text input field you purposely changed).

I have also manually tested other inputs on this form... changing the values of any one should not affect any of the others now. We will likely want to add unit testing to this as part of our epic to improve connection creation/editing in Q3.

[timroes]

I've tested this, and unfortunately it doesn't seem to fix the linked issue. I still see the values changing when tying in the name field. I have some suspicion about the broken code, but will need to dig a bit deeper here.

[teallarson]

I've tested this, and unfortunately it doesn't seem to fix the linked issue. I still see the values changing when tying in the name field. I have some suspicion about the broken code, but will need to dig a bit deeper here.

Thanks. I wonder why it did appear to fix it for me locally. That's also not great. I wonder if it's related to how we're currently both passing in the connection values from the page and also calculating them in the form?

[timroes]

Superseeded by #15332