Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source Harvest: increase unit test coverage at least 90% #15220

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Aug 2, 2022

What

#15219 - Source Harvest: increase unit test coverage at least 90%

How

Increased unit test coverage to 90% and updated docs to template.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

@lazebnyi lazebnyi linked an issue Aug 2, 2022 that may be closed by this pull request
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 2, 2022
docs/integrations/sources/harvest.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the area/documentation Improvements or additions to documentation label Aug 8, 2022
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 8, 2022

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/2817705675
✅ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/2817705675
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        82      6    93%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  77     17    78%
source_acceptance_test/tests/test_core.py              355    107    70%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                 1023    247    76%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_harvest/auth.py          11      0   100%
source_harvest/__init__.py       2      0   100%
source_harvest/source.py        33      1    97%
source_harvest/streams.py      166     16    90%
------------------------------------------------
TOTAL                          212     17    92%

Build Passed

Test summary info:

All Passed

@lazebnyi lazebnyi merged commit c39a7c4 into master Aug 8, 2022
@lazebnyi lazebnyi deleted the lazebnyi/15219-harvest-increase-unittest-coverage branch August 8, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Harvest: increase unit test coverage at least 90%
3 participants