Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source-plaid: minimum last updated datetime support added for Capital One items #15228

Closed
wants to merge 55 commits into from
Closed

Source-plaid: minimum last updated datetime support added for Capital One items #15228

wants to merge 55 commits into from

Conversation

UsmanAli99
Copy link
Contributor

What

  • min_last_updated_datetime support added for source-plaid Capital One items. Here is a issue

How

  • Use start_date field and create a format for min_last_updated_datetime.

  • Add optional argument to AccountsBalanceGetRequest.

Recommended reading order

  1. airbyte/airbyte-integrations/connectors/source-plaid/source_plaid/source.py

🚨 User Impact 🚨

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Screenshot from 2022-08-03 11-29-27

Integration

No integration test

Acceptance

For additionalProperties=false in spec.json file test_additional_properties_is_true fails. Which is already a known issue
Screenshot from 2022-08-03 11-32-54

  • For additionalProperties=true

Screenshot from 2022-08-03 11-35-45

@CLAassistant
Copy link

CLAassistant commented Aug 3, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 3, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 3, 2022
@UsmanAli99 UsmanAli99 changed the title Fix/plaid capital one Source-plaid: minimum last updated datetime support added for Capital One items Aug 3, 2022
annalvova05 and others added 16 commits August 3, 2022 15:22
@annalvova05 @octavia-squidington-iii @UsmanAli99
🎉 Source Okta: return deprovisioned users (airbytehq#15001)
b328672 
* add statuses to user filtering

* bump version

* upd

* add comment

* auto-bump connector version [ci skip]

* format

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@teallarson @timroes @UsmanAli99
🪟 🎨 Trial end banner (airbytehq#14913)
47ece16 
* alert banner

* cleanup

* cleanup

* review cleanup

* Minor cleanup

Co-authored-by: Tim Roes <tim@airbyte.io>
@edmundito @timroes @UsmanAli99
🪟 🎨 Update layout of create connection and replication settings pages…
0bf971e 
… to mach design (airbytehq#14946)

* Update ConnectionForm to match design
* Split sections into cards
* Update connection name label to heading
* Move create/edit buttons outside of card
* Fix spacing to match design
* Remove noTitles prop from CreateConnectionContent component

* Update OperationsSection title to match the rest of the sections

* Update connection name text to show that it's required

* Divide streams into sections, center dont worry teext

* Wrap SyncCatalogField in a div to prevent style impact from parent

* Remove don't worry message from create connection page

* Update resizing of left fields and right fields to match design. Now fields should stop at certain width of page

* Move replication and tarnsformation section in connection form to its own card

* Move OperationSection within same render condition as CreateControls

* Apply design changes to main page with scroll, connection page title, and status main info

* Update main page with scroll to only scroll x on the content, not the whole page
* Update connection page title to all SCSS, add xl horizontal padding to match content
* Update status main info to be more flexible on window resize
* Remove extra div from status view that was adding extra horizontal margin to the card

* Fix minor issues

Co-authored-by: Tim Roes <tim@airbyte.io>
@lazebnyi @octavia-squidington-iii @UsmanAli99
🐛 Source Google Ads: Fix wrong schema for `ad_group_criterion.topic.p…
53a270b 
…ath` and shifted `Campaigns` stream to non-managers stream list (airbytehq#15084)

* Fix wrong schema for ad_group_criterion.topic.path

* Shifted campaingns stream to non-manager streams

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@lazebnyi @UsmanAli99
🎉Source PayPal Transactions: Updated docs (airbytehq#15105)
314a6e4 
* Updated docs

* Updated docs
@sashaNeshcheret @edgao
@octavia-squidington-iii @UsmanAli99
Snowflake destination: support key pair authentication (airbytehq#14388)
27f39c7 
* Snowflake destination: support key pair authentication.

* Snowflake destination: update docs

* Snowflake destination: support key pair authentication for normalization, added tests

* Snowflake destination: update normalization

* Snowflake destination: update way of read secrets for test

* Snowflake destination: moved test to another class for test purpose

* Snowflake destination: update secrets for test purpose

* Snowflake destination: revert changes added for test purpose

* Snowflake destination: changes added for test purpose

* Snowflake destination: updated required fields in specs

* Snowflake destination: clean up

* Snowflake destination: support encrypted key pair authentication (airbytehq#14589)

* Snowflake destination: add support for ecrypted private key

* Snowflake destination: temp reverting for test purpose

* Revert "Snowflake destination: temp reverting for test purpose"

This reverts commit 260ecce.

* Snowflake destination: add passphrase and remove auth_type from required fields

* Snowflake destination: format code

* Snowflake destination: clean up

* Snowflake destination: update docs

* Normalization for Snowflake destination: added unit tests and change file creating process

* Normalization for Snowflake destination: renamed property passphrase to password

* Snowflake destination: apply changes from normalization

* Snowflake destination: clean code

* Snowflake destination: clean up

* auto-bump connector version [ci skip]

Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@girarda @UsmanAli99
[low-code-connectors] Disable parse-time interpolation in favor of ru…
bf251f1 
…ntime-only (airbytehq#14923)

* abstract auth token

* basichttp

* remove prints

* docstrings

* get rid of parse-time interpolation

* always pass options through

* delete print

* delete misleading comment

* delete note

* reset

* pass down options

* delete duplicate file

* missing test

* refactor test

* rename to '$options'

* rename to ''

* interpolatedauth

* fix tests

* fix

* docstrings

* update docstring

* docstring

* update docstring

* remove extra field

* undo

* rename to runtime_parameters

* docstring

* update

* / -> *

* update template

* rename to options

* Add examples

* update docstring

* Update test

* newlines

* rename kwargs to options

* options init param

* delete duplicate line

* type hints

* update docstring

* Revert "delete duplicate line"

This reverts commit 4255d5b.

* delete duplicate code from bad merge

* rename file

* bump cdk version
@davinchia @snyk-bot @UsmanAli99
fix: airbyte-integrations/connector-templates/source-python-http-api/…
2cd8f10 
…Dockerfile to reduce vulnerabilities (airbytehq#15111)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-ALPINE315-BUSYBOX-2440607
- https://snyk.io/vuln/SNYK-ALPINE315-BUSYBOX-2440607
- https://snyk.io/vuln/SNYK-ALPINE315-OPENSSL-2941810
- https://snyk.io/vuln/SNYK-ALPINE315-OPENSSL-2941810
- https://snyk.io/vuln/SNYK-ALPINE315-ZLIB-2434420

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
@davydov-d @octavia-squidington-iii @UsmanAli99
Source Hubspot: implement new stream to read associations in incremen…
9fd0344 
…tal mode (airbytehq#15099)

* airbytehq#359 oncall - source hubspot: implement new stream to read associations in incremental mode

* airbytehq#359 source hubspot: upd changelog

* airbytehq#359 source hubspot: do not pass identifiers

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@annalvova05 @UsmanAli99
Source PayPal Transactions: increase unit tests (airbytehq#15098)
e23e7e8 
* add unit tests

* add unit tests

* up

* bump version

* upd

* upd

* revert bump version
@davydov-d @octavia-squidington-iii @UsmanAli99
Source Hubspot: revert v0.1.78 (airbytehq#15144)
c9b2c0e 
* Revert "Source Hubspot: implement new stream to read associations in incremental mode (airbytehq#15099)"

This reverts commit dd109de.

* airbytehq#359 rollback

* hubspot: upd changelog

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@grubberr @UsmanAli99
🎉 Source Github: bugfix schemas for streams deployments, `workflow_…
37e3b02 
…runs`, `teams` (airbytehq#15049)

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@NipunaPrashan @UsmanAli99
Fix yaml formatting error (airbytehq#15148)
78dbeb2
@grubberr @UsmanAli99
pin flake8==4.0.1 (airbytehq#15155)
1b2e622 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@nialloriordan @UsmanAli99
Docs: Fix link to roadmap (airbytehq#15103)
80a1814 
Replace the broken markdown link and add an external link to the roadmap.
@xpuska513 @UsmanAli99
fix: Fix extraEnv, Update OSS charts (airbytehq#15159)
14919f2 
* fix: Add new labels to all charts + fix indent issue for extraEnv

* fix: Update docs, add extraContainers parameter into dependent charts
@UsmanAli99 UsmanAli99 requested a review from a team as a code owner August 3, 2022 10:24
@github-actions github-actions bot added area/platform issues related to the platform area/scheduler area/server area/worker Related to worker CDK Connector Development Kit kubernetes normalization area/frontend Related to the Airbyte webapp labels Aug 3, 2022
@UsmanAli99 UsmanAli99 closed this Aug 3, 2022
@UsmanAli99 UsmanAli99 deleted the fix/plaid-capital-one branch August 3, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation area/frontend Related to the Airbyte webapp area/platform issues related to the platform area/scheduler area/server area/worker Related to worker bounty CDK Connector Development Kit community connectors/destination/bigquery connectors/destination/bigquery-denormalized connectors/destination/postgres connectors/destination/snowflake connectors/source/cockroachdb connectors/source/github connectors/source/google-ads connectors/source/hubspot connectors/source/mssql connectors/source/okta connectors/source/oracle connectors/source/oracle-strict-encrypt connectors/source/paypal-transaction connectors/source/plaid connectors/source/redshift connectors/source/s3 connectors/source/scaffold-source-http connectors/source/shortio connectors/source/stripe kubernetes normalization
Projects
No open projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.