Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added confirmation message after selecting "Remove" in Access Management #15404

Conversation

matter-q
Copy link
Contributor

@matter-q matter-q commented Aug 8, 2022

What

Closes #14654

How

Added confirmation message after selecting "Remove" in Access Management

Loom

https://www.loom.com/share/d36d8e2ac70a4c25a0e6307c3fe9a1b4

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Aug 8, 2022
@matter-q matter-q marked this pull request as ready for review August 8, 2022 12:58
@matter-q matter-q requested a review from a team as a code owner August 8, 2022 12:58
Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code - LGTM.
Also tested locally - all work as should. 👍🏻

@matter-q matter-q merged commit d4abf61 into master Aug 8, 2022
@matter-q matter-q deleted the mark/confirmation-message-after-selecting-remove-in-access-management-settings branch August 8, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirmation message after selecting "Remove" in Access Management
2 participants