Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more Error Prone PMD rules #15491

Merged
merged 14 commits into from
Sep 7, 2022
Merged

Implement more Error Prone PMD rules #15491

merged 14 commits into from
Sep 7, 2022

Conversation

alovew
Copy link
Contributor

@alovew alovew commented Aug 9, 2022 •
edited
Loading

Implement error prone pmd rules

@github-actions github-actions bot added area/api Related to the api area/platform issues related to the platform area/scheduler area/server area/worker Related to worker labels Aug 9, 2022
@alovew alovew requested a review from a team as a code owner September 6, 2022 22:13
@alovew alovew temporarily deployed to more-secrets September 6, 2022 22:15 Inactive
@alovew alovew temporarily deployed to more-secrets September 6, 2022 22:22 Inactive
@alovew alovew temporarily deployed to more-secrets September 6, 2022 22:28 Inactive
@alovew alovew temporarily deployed to more-secrets September 6, 2022 22:58 Inactive
@alovew alovew temporarily deployed to more-secrets September 6, 2022 23:01 Inactive
jdpgrailsdev
jdpgrailsdev approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@alovew alovew temporarily deployed to more-secrets September 7, 2022 16:23 Inactive
@alovew alovew temporarily deployed to more-secrets September 7, 2022 17:12 Inactive
@alovew alovew temporarily deployed to more-secrets September 7, 2022 17:18 Inactive
@alovew alovew temporarily deployed to more-secrets September 7, 2022 17:34 Inactive
@alovew alovew temporarily deployed to more-secrets September 7, 2022 18:42 Inactive
@alovew alovew temporarily deployed to more-secrets September 7, 2022 18:56 Inactive
@alovew alovew merged commit d856731 into master Sep 7, 2022
@alovew alovew deleted the anne/more-error-prone-rules branch September 7, 2022 20:20
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 12, 2022
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@alovew @robbinhan
Implement more Error Prone PMD rules (airbytehq#15491)
d9ed6c8 
* AvoidFieldNameMatchingTypeName rule
* AvoidInstanceofChecksInCatchClause
* compareObjectsWithEquals
* DoNotTerminateVM and ConstructorCallsOverridableMethod
* EmptyIfStmt and EmptyStatementNotInLoop
* ImplicitSwitchFallThrough, InvalidLogMessageFormat, and MoreThanOneLogger
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@alovew @jhammarstedt
Implement more Error Prone PMD rules (airbytehq#15491)
5a17bf0 
* AvoidFieldNameMatchingTypeName rule
* AvoidInstanceofChecksInCatchClause
* compareObjectsWithEquals
* DoNotTerminateVM and ConstructorCallsOverridableMethod
* EmptyIfStmt and EmptyStatementNotInLoop
* ImplicitSwitchFallThrough, InvalidLogMessageFormat, and MoreThanOneLogger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

Assignees
No one assigned
Labels
area/api Related to the api area/platform issues related to the platform area/protocol area/scheduler area/server area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alovew @jdpgrailsdev