🎉 New Destination: TiDB #15592
Merged
🎉 New Destination: TiDB #15592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/connectors
|
Awesome contribution @Daemonxiao I'll ask the team to review next week! |
|
/test connector=bases/base-normalization
Build FailedTest summary info: |
|
/test connector=connectors/destination-tidb
Build FailedTest summary info: |
|
@marcosmarxm It seems something is wrong with pflake8. csachs/pyproject-flake8#13 Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 188, in _run_module_as_main
mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 147, in _get_module_details
return _get_module_details(pkg_main_name, error)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 111, in _get_module_details
__import__(pkg_name)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/pflake8/__init__.py", line 54, in <module>
class ModifiedConfigFileFinder(flake8.options.config.ConfigFileFinder):
AttributeError: module 'flake8.options.config' has no attribute 'ConfigFileFinder' |
zhangyangyu
reviewed
Aug 23, 2022
zhangyangyu
reviewed
Aug 23, 2022
Co-authored-by: Xiang Zhang <angwerzx@126.com>
zhangyangyu
approved these changes
Aug 23, 2022
|
/test connector=bases/base-normalization
Build FailedTest summary info: |
|
@marcosmarxm Integration test reported that |
|
@Daemonxiao yep, I'll take a look. Looks your contributation is close to be merged! |
|
/test connector=bases/base-normalization
Build PassedTest summary info: |
marcosmarxm
approved these changes
Aug 31, 2022
|
/publish connector=bases/base-normalization |
|
/publish connector=connectors/destination-tidb |
|
/publish connector=connectors/destination-tidb |
|
/publish connector=connectors/destination-tidb
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
/publish connector=bases/base-normalization
if you have connectors that successfully published but failed definition generation, follow step 4 here |
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Add new destination-tidb * support sync * Add normalization-tidb * fix failed tests * Add unnest marco * fmt * Add new destination-tidb * support sync * Add normalization-tidb * fix failed tests * Add unnest marco * fmt * fmt * fix integration test * Update docs/integrations/destinations/tidb.md Co-authored-by: Xiang Zhang <angwerzx@126.com> * Update doc * Update doc * Update doc * bump normalization version * update normalization changelog * run format * add dest def * generat spec Co-authored-by: Xiang Zhang <angwerzx@126.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add new destination TiDB with supporting normalization.
How
Describe the solution
Recommended reading order
TiDBDestination.javaTiDBSQLNameTransformer.javaTiDBSqlOperations.javatransform.pystream_processor.pyPre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdTests
Integration
Destination Integration Test
Normalization Integration Test