🪟 🎉 Add optional invite user hint to connector create pages #15799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
|
Maybe add |
edmundito
force-pushed
the
edmundito/invite-user-from-connector
branch
from
c7fc8e5
to
0975ec5
Compare
edmundito
force-pushed
the
edmundito/invite-user-from-connector
branch
from
111f796
to
547a909
Compare
edmundito
force-pushed
the
edmundito/invite-user-from-connector
branch
2 times, most recently
from
44fc8fd
to
449a769
Compare
edmundito
force-pushed
the
edmundito/invite-user-from-connector
branch
2 times, most recently
from
bc2fa98
to
1ca13bf
Compare
edmundito
force-pushed
the
edmundito/invite-user-from-connector
branch
from
1ca13bf
to
fb1c179
Compare
|
Rebased and ready for review! |
krishnaglick
reviewed
Oct 6, 2022
Comment on lines
28
to
30
| toggleInviteUsersModalOpen: (open) => { | ||
| toggleIsOpen(open); | ||
| }, |
There was a problem hiding this comment.
Why not just export the setState function instead of wrapping it?
| const mockUseExperiment = jest.fn<ReturnType<typeof useExperiment>, Parameters<typeof useExperiment>>(); | ||
| jest.doMock("hooks/services/Experiment", () => ({ | ||
| useExperiment: mockUseExperiment, | ||
| })); |
There was a problem hiding this comment.
I've found a different pattern for this. You might find it a little nicer, but up to you!
Comment on lines
+32
to
+36
| onClick={() => { | ||
| toggleInviteUsersModalOpen(); | ||
| }} |
There was a problem hiding this comment.
Nit:
Suggested change
| onClick={() => { | |
| toggleInviteUsersModalOpen(); | |
| }} | |
| onClick={toggleInviteUsersModalOpen} |
josephkmh
reviewed
Oct 7, 2022
airbyte-webapp/src/packages/cloud/views/users/InviteUsersHint/InviteUsersHint.tsx
Show resolved
Hide resolved
airbyte-webapp/src/packages/cloud/services/users/InviteUsersModalService.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/packages/cloud/views/users/InviteUsersHint/InviteUsersHint.module.scss
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/packages/cloud/views/users/InviteUsersHint/InviteUsersHint.test.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/packages/cloud/views/users/InviteUsersHint/InviteUsersHint.test.tsx
Show resolved
Hide resolved
Move cloud settings paths to its own file
edmundito
force-pushed
the
edmundito/invite-user-from-connector
branch
from
8edb341
to
28fd5f3
Compare
edmundito
requested review from
josephkmh and
a team
and removed request for
ambirdsall
josephkmh
approved these changes
Oct 12, 2022
This was referenced Oct 13, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…q#15799) * Add InviteUsersModalService and migrate UserSettingsView to use it * Add InviteUsersHint component and show in create source/destination pages * Update InviteUsersHint to use Text component and spacing variables * Add experiments for showing invite user hint Move cloud settings paths to its own file * Update Invite hint to lazy load with suspense * Fix invite user modal experiment names and add unit test * Rename CloudInviteUsersHint component file * Add notification when users are invited * Fix copy and remove plural form of invite success dialog * Show invite users hint in connector create form page * Fix stylelint issue in InviteUsersHint * Fix access management path in InviteUsersHint * Fix button text in UserSettingsView * Fix linkToUsersPage type in experiments iface * Cleanup code * Cleanup scss path in InviteUsersHint.module * update InviteUsersHint layout to be consistent with or without button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #15660
Adds the ability to invite users from the source or destinations create pages when running in cloud mode. It can be enabled from experiment flags and provides the option to show as a link to the page or a direct modal.
How
Updates the invite user modal to be invoked from a service.
The service is then used in invite hint component to invoke the modal.
The component is lazy loaded since it's only needed when running in cloud.
Recommended reading order
airbyte-webapp/src/packages/cloud/views/users/InviteUsersHint/InviteUsersHint.tsxairbyte-webapp/src/components/CloudInviteUsersHint/OptionalInviteUsersHint.tsxairbyte-webapp/src/pages/SourcePage/pages/CreateSourcePage/CreateSourcePage.tsxairbyte-webapp/src/pages/DestinationPage/pages/CreateDestinationPage/CreateDestinationPage.tsxTests
TODO