-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[source-sendgrid] [source-sentry] use latest cdk w/ file parse fixes and fix sendgrid messages stream bug #15911
Conversation
@@ -67,7 +67,7 @@ definitions: | |||
datetime: "{{ config['start_time'] }}" | |||
datetime_format: "%s" | |||
end_datetime: | |||
datetime: "{{ now_utc() }}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes time parsing that was failing when it got an unexpected }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this cause any test failures?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't, but i think the reason was because the messages
stream uses an API endpoint that our test creds don't have access to which then returns a 400 error code. I haven't dug into how our unit tests from a month or two ago are working, but its possible they see the same error and move on to the next set of streams
/test connector=connectors/source-sentry
Build PassedTest summary info:
|
/test connector=connectors/source-sendgrid
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (remember to update changelog)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, missing changelog update and connector version bump.
/publish connector=connectors/source-sendgrid
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-sentry
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…thub.com/airbytehq/airbyte into brian/bump_sendgrid_sentry_to_latest_CDK
…and fix sendgrid messages stream bug (#15911) * use latest cdk w/ file parse fixes and fix sendgrid messages stream bug * roll dockerfile and changelog * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
…and fix sendgrid messages stream bug (#15911) * use latest cdk w/ file parse fixes and fix sendgrid messages stream bug * roll dockerfile and changelog * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Upgrade the sendgrid and sentry connectors to use the latest CDK which fixes a json schema parse issue as per
0.1.79
.How
The latest CDK can properly read json files via #15814