add a test to keep available cron time zones in sync #15929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfsiega-airbyte
requested review from
a team and
c-p-b
and removed request for
a team
github-actions
bot
added
area/platform
davinchia
reviewed
Aug 24, 2022
Comment on lines
659
to
671
| final StandardSync actual = new StandardSync(); | ||
| ConnectionScheduleHelper.populateSyncFromScheduleTypeAndData(actual, | ||
| ConnectionScheduleType.CRON, new ConnectionScheduleData() | ||
| .cron(new ConnectionScheduleDataCron() | ||
| .cronTimeZone(expectedTimezone) | ||
| .cronExpression(EXPECTED_CRON_EXPRESSION))); | ||
| assertEquals(ScheduleType.CRON, actual.getScheduleType()); | ||
| assertEquals(expectedTimezone, actual.getScheduleData().getCron().getCronTimeZone()); | ||
| assertEquals(EXPECTED_CRON_EXPRESSION, actual.getScheduleData().getCron().getCronExpression()); | ||
| } catch (IllegalArgumentException | JsonValidationException e) { | ||
| throw (RuntimeException) new RuntimeException( | ||
| "One of the timezones is not supported - update airbyte-webapp/src/config/availableCronTimeZones.json!") | ||
| .initCause(e); |
There was a problem hiding this comment.
Dumb question: what here is actually validating the cron string is valid? Put another way, trying to understand what part of the call chain changing here will require us changing the FE supported time zones.
There was a problem hiding this comment.
It's actually not super obvious, but: https://github.com/airbytehq/airbyte/blob/master/airbyte-server/src/main/java/io/airbyte/server/handlers/helpers/ConnectionScheduleHelper.java#L62 (which is in the API codepath) will throw an exception if we give it a bad timezone.
There was a problem hiding this comment.
nice! can we add this in as a comment for future readers?
davinchia
approved these changes
Aug 24, 2022
rodireich
pushed a commit
that referenced
this pull request
Aug 25, 2022
* add a test to keep available cron time zones in sync * clarify test comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a test to keep the available cron timezone list in sync between frontend and backend.
How
(1) copy the frontend list into the server package; (2) for each timezone, check that the API accepts it; (3) leave a large comment and test failure message to point on that the frontend list should be updated if the test fails.