Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source File: increase unit test coverage at least 90% #15933

Merged
merged 5 commits into from
Aug 26, 2022

Conversation

arsenlosenko
Copy link
Contributor

@arsenlosenko arsenlosenko commented Aug 24, 2022

What

Resolving:
#15508

How

Increased unit test coverage to 90%.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

@arsenlosenko arsenlosenko self-assigned this Aug 24, 2022
@CLAassistant
Copy link

CLAassistant commented Aug 24, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 24, 2022
@arsenlosenko arsenlosenko changed the title [WIP] Added inital test setup for client.py, added WIP tests for source.py [WIP] Source File: unit tests Aug 24, 2022
@lazebnyi lazebnyi marked this pull request as ready for review August 26, 2022 02:05
@lazebnyi
Copy link
Collaborator

lazebnyi commented Aug 26, 2022

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2930837980
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2930837980
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       270     38    86%
source_file/source.py        51     27    47%
---------------------------------------------
TOTAL                       323     65    80%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/source.py        51      0   100%
source_file/__init__.py       2      0   100%
source_file/client.py       270     33    88%
---------------------------------------------
TOTAL                       323     33    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 26 passed, 1 skipped in 63.40s (0:01:03) ===================

@lazebnyi lazebnyi changed the title [WIP] Source File: unit tests 🎉Source File: increase unit test coverage at least 90% Aug 26, 2022
@lazebnyi lazebnyi merged commit 7d6dfac into master Aug 26, 2022
@lazebnyi lazebnyi deleted the arsenlosenko/15508-source-file-test-coverage branch August 26, 2022 10:18
@lazebnyi lazebnyi linked an issue Aug 26, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source File: Improve unit test coverage to 90%
4 participants