adding credit_block_id to columns obtained from Orb API #16017

ajmhatch · 2022-08-26T16:28:56Z

What

Adding credit_block_id to credits_ledger_entries schema

How

Unnesting from credit_block in same manner as block_expiry_date and credit_block_per_unit_cost_basis.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Integration

Acceptance

ChristopheDuong · 2022-08-26T16:30:24Z

/test connector=connectors/source-orb

🕑 connectors/source-orb https://github.com/airbytehq/airbyte/actions/runs/2935168026
❌ connectors/source-orb https://github.com/airbytehq/airbyte/actions/runs/2935168026
🐛 https://gradle.com/s/ijnodkrb6nrao

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_additional_properties_is_true[inputs0] - ...
======================== 1 failed, 28 passed in 57.20s =========================

ajmhatch · 2022-08-26T16:59:06Z

/test connector=connectors/source-orb

🕑 connectors/source-orb https://github.com/airbytehq/airbyte/actions/runs/2935313335
✅ connectors/source-orb https://github.com/airbytehq/airbyte/actions/runs/2935313335
Python tests coverage:

Name                     Stmts   Miss  Cover
--------------------------------------------
source_orb/__init__.py       2      0   100%
source_orb/source.py       194     21    89%
--------------------------------------------
TOTAL                      196     21    89%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

All Passed

airbyte-integrations/connectors/source-orb/source_orb/source.py

updating changelog for orb credit block id upgrade

ajmhatch · 2022-08-26T17:59:53Z

/publish connector=connectors/source-orb

🕑 Publishing the following connectors:
connectors/source-orb
https://github.com/airbytehq/airbyte/actions/runs/2935633917

Connector	Did it publish?	Were definitions generated?
connectors/source-orb	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

zzztimbo · 2022-08-26T18:08:58Z

/publish connector=connectors/source-orb

🕑 Publishing the following connectors:
connectors/source-orb
https://github.com/airbytehq/airbyte/actions/runs/2935687763

Connector	Did it publish?	Were definitions generated?
connectors/source-orb	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

CLAassistant · 2022-08-26T18:26:57Z

All committers have signed the CLA.

zzztimbo · 2022-08-26T18:28:31Z

/publish connector=connectors/source-orb

🕑 Publishing the following connectors:
connectors/source-orb
https://github.com/airbytehq/airbyte/actions/runs/2935789254

Connector	Did it publish?	Were definitions generated?
connectors/source-orb	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* adding credit_block_id to columns obtained from Orb API * switch additional properties from false to true * Update orb.md (#16020) updating changelog for orb credit block id upgrade * bump image tag * auto-bump connector version [ci skip] Co-authored-by: Tim Chan <tim@chan.net> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

adding credit_block_id to columns obtained from Orb API

b932988

ajmhatch self-assigned this Aug 26, 2022

octavia-squidington-iii added the connectors/source/orb label Aug 26, 2022

github-actions bot added the area/connectors Connector related issues label Aug 26, 2022

switch additional properties from false to true

a97c408

ChristopheDuong reviewed Aug 26, 2022

View reviewed changes

airbyte-integrations/connectors/source-orb/source_orb/source.py Show resolved Hide resolved

Update orb.md (#16020)

5794d70

updating changelog for orb credit block id upgrade

github-actions bot added the area/documentation Improvements or additions to documentation label Aug 26, 2022

ajmhatch marked this pull request as ready for review August 26, 2022 18:01

ChristopheDuong approved these changes Aug 26, 2022

View reviewed changes

bump image tag

0730f25

auto-bump connector version [ci skip]

67736d7

alex-gron merged commit 00aca98 into master Aug 26, 2022

alex-gron deleted the alyssa/update_orb_columns branch August 26, 2022 18:56

octavia-squidington-iii mentioned this pull request Aug 26, 2022

Bump Airbyte version from 0.40.2 to 0.40.3 #16028

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding credit_block_id to columns obtained from Orb API #16017

adding credit_block_id to columns obtained from Orb API #16017

ajmhatch commented Aug 26, 2022 •

edited

Loading

ChristopheDuong commented Aug 26, 2022 •

edited by github-actions bot

Loading

ajmhatch commented Aug 26, 2022 •

edited by github-actions bot

Loading

ajmhatch commented Aug 26, 2022 •

edited by github-actions bot

Loading

zzztimbo commented Aug 26, 2022 •

edited by github-actions bot

Loading

CLAassistant commented Aug 26, 2022 •

edited

Loading

zzztimbo commented Aug 26, 2022 •

edited by github-actions bot

Loading

adding credit_block_id to columns obtained from Orb API #16017

adding credit_block_id to columns obtained from Orb API #16017

Conversation

ajmhatch commented Aug 26, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

ChristopheDuong commented Aug 26, 2022 • edited by github-actions bot Loading

Build Failed

ajmhatch commented Aug 26, 2022 • edited by github-actions bot Loading

Build Passed

ajmhatch commented Aug 26, 2022 • edited by github-actions bot Loading

zzztimbo commented Aug 26, 2022 • edited by github-actions bot Loading

CLAassistant commented Aug 26, 2022 • edited Loading

zzztimbo commented Aug 26, 2022 • edited by github-actions bot Loading

ajmhatch commented Aug 26, 2022 •

edited

Loading

ChristopheDuong commented Aug 26, 2022 •

edited by github-actions bot

Loading

ajmhatch commented Aug 26, 2022 •

edited by github-actions bot

Loading

ajmhatch commented Aug 26, 2022 •

edited by github-actions bot

Loading

zzztimbo commented Aug 26, 2022 •

edited by github-actions bot

Loading

CLAassistant commented Aug 26, 2022 •

edited

Loading

zzztimbo commented Aug 26, 2022 •

edited by github-actions bot

Loading