Add protocol version migration #16145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alovew
commented
Aug 30, 2022
airbyte-db/db-lib/build.gradle
Outdated
| @@ -14,7 +14,7 @@ dependencies { | |||
| implementation libs.flyway.core | |||
|
|
|||
| // Mark as compile only to avoid leaking transitively to connectors | |||
| compileOnly libs.platform.testcontainers.postgresql | |||
| implementation libs.platform.testcontainers.postgresql | |||
There was a problem hiding this comment.
@jdpgrailsdev I saw that you wrote this -- the create migration script was broken and changing this from compileOnly to implementation fixes it, but I'm not 100% sure it's the right fix since I'm not sure what you mean by 'leaking transitively to connectors'
alovew
force-pushed
the
anne/add-protocol-version-to-actor-definition
branch
from
9bca767
to
3ed4309
Compare
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Add protocol version migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add protocol_version column to actor_definition