-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protocol version migration #16145
Conversation
airbyte-db/db-lib/build.gradle
Outdated
@@ -14,7 +14,7 @@ dependencies { | |||
implementation libs.flyway.core | |||
|
|||
// Mark as compile only to avoid leaking transitively to connectors | |||
compileOnly libs.platform.testcontainers.postgresql | |||
implementation libs.platform.testcontainers.postgresql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdpgrailsdev I saw that you wrote this -- the create migration script was broken and changing this from compileOnly to implementation fixes it, but I'm not 100% sure it's the right fix since I'm not sure what you mean by 'leaking transitively to connectors'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9bca767
to
3ed4309
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Add protocol version migration
Add protocol_version column to actor_definition