🐛 Avro compatible destinations: fix field name clashing with combined restrict #16243

tuliren · 2022-09-01T22:03:37Z

What

This is a follow-up PR for destination-s3: added possibly failing test case for Json Avro converter. #14492, which has the actual fix.
Publish Avro related destinations to fix field name clashing with combined restrict (anyOf, oneOf, allOf).
Move the new test case to the end, and add two more test cases.

Version bumps

Destination Connector	Old	New
destination-redshift	0.3.48	0.3.49
destination-bigquery-denormalized	1.1.15	1.1.16
destination-snowflake	0.4.34	0.4.35
destination-s3	0.3.14	0.3.15
destination-bigquery	1.1.15	1.1.16
destination-gcs	0.2.10	0.2.11
destination-databricks	0.2.6	unpublished

github-actions · 2022-09-01T22:33:52Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

This reverts commit f10497e.

github-actions · 2022-09-01T22:48:12Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-bigquery
destination-gcs
destination-redshift
destination-snowflake
destination-databricks
destination-jdbc
destination-bigquery-denormalized
destination-s3

github-actions · 2022-09-01T23:12:08Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-bigquery
destination-redshift
destination-snowflake
destination-databricks
destination-gcs
destination-s3
destination-bigquery-denormalized
destination-jdbc

tuliren · 2022-09-01T23:19:56Z

/publish connector=connectors/destination-s3,connectors/destination-gcs,connectors/destination-redshift,connectors/destination-bigquery,connectors/destination-bigquery-denormalized,connectors/destination-snowflake,connectors/destination-databricks

🕑 Publishing the following connectors:
connectors/destination-s3,connectors/destination-gcs,connectors/destination-redshift,connectors/destination-bigquery,connectors/destination-bigquery-denormalized,connectors/destination-snowflake,connectors/destination-databricks
https://github.com/airbytehq/airbyte/actions/runs/2975613615

Connector	Did it publish?	Were definitions generated?
connectors/destination-gcs	✅	✅
connectors/destination-s3	✅	✅
connectors/destination-bigquery-denormalized	✅	✅
connectors/destination-redshift	✅	✅
connectors/destination-bigquery	✅	✅
connectors/destination-databricks	❌	❌
connectors/destination-snowflake	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

… into liren/publish-s3

github-actions · 2022-09-02T00:01:41Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-databricks
destination-gcs
destination-bigquery-denormalized
destination-s3
destination-redshift
destination-bigquery
destination-jdbc
destination-snowflake

… into liren/publish-s3

github-actions · 2022-09-02T00:05:48Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-jdbc
destination-bigquery-denormalized
destination-redshift
destination-snowflake
destination-gcs
destination-databricks
destination-s3
destination-bigquery

github-actions · 2022-09-02T00:06:13Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-bigquery-denormalized
destination-bigquery
destination-databricks
destination-snowflake
destination-gcs
destination-redshift
destination-jdbc
destination-s3

… into liren/publish-s3

github-actions · 2022-09-02T00:12:51Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-redshift
destination-bigquery
destination-bigquery-denormalized
destination-databricks
destination-jdbc
destination-snowflake
destination-gcs
destination-s3

tuliren · 2022-09-02T00:31:23Z

Databricks integration test failed. Will exclude it from the publication for now.

github-actions · 2022-09-02T00:31:35Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-bigquery-denormalized
destination-redshift
destination-jdbc
destination-bigquery
destination-gcs
destination-snowflake
destination-databricks
destination-s3

… into liren/publish-s3

github-actions · 2022-09-02T00:53:28Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-bigquery
destination-snowflake
destination-databricks
destination-gcs
destination-redshift
destination-bigquery-denormalized
destination-jdbc
destination-s3

…strict (airbytehq#16243) * Add test case for allOf and oneOf * Bump version * Add pr id * Bump gcs version * Bump dest jdbc * Bump redshift * Bump snowflake * Bump databricks * Bump bigquery * Revert "Bump dest jdbc" This reverts commit f10497e. * Use a new pat to avoid api rate limit * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] * Revert databricks bump * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Add test case for allOf and oneOf

b79f652

github-actions bot added the area/connectors Connector related issues label Sep 1, 2022

octavia-squidington-iii added the connectors/destination/s3 label Sep 1, 2022

tuliren added 2 commits September 1, 2022 15:28

Bump version

7036740

Add pr id

d000146

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 1, 2022

tuliren added 6 commits September 1, 2022 15:39

Bump gcs version

3cb3f5f

Bump dest jdbc

f10497e

Bump redshift

189a02b

Bump snowflake

0777b5b

Bump databricks

f82a612

Bump bigquery

6f434cf

octavia-squidington-iii added connectors/destination/bigquery connectors/destination/bigquery-denormalized connectors/destination/snowflake connectors/destination/redshift connectors/destination/databricks connectors/destination/gcs connectors/destination/jdbc labels Sep 1, 2022

This comment was marked as outdated.

Sign in to view

Revert "Bump dest jdbc"

f84a5bb

This reverts commit f10497e.

Use a new pat to avoid api rate limit

fc04a4c

This comment was marked as outdated.

Sign in to view

tuliren temporarily deployed to more-secrets September 1, 2022 23:13 Inactive

octavia-squidington-iii added 2 commits September 1, 2022 23:48

auto-bump connector version [ci skip]

f6f6eb8

auto-bump connector version [ci skip]

538cf96

Merge branch 'liren/publish-s3' of https://github.com/airbytehq/airbyte…

a7e5d60

… into liren/publish-s3

octavia-squidington-iii temporarily deployed to more-secrets September 2, 2022 00:03 Inactive

octavia-squidington-iii added 4 commits September 2, 2022 00:04

auto-bump connector version [ci skip]

caaac47

Merge branch 'liren/publish-s3' of https://github.com/airbytehq/airbyte…

deee467

… into liren/publish-s3

auto-bump connector version [ci skip]

c2a7c86

Merge branch 'liren/publish-s3' of https://github.com/airbytehq/airbyte…

6e22549

… into liren/publish-s3

octavia-squidington-iii temporarily deployed to more-secrets September 2, 2022 00:07 Inactive

octavia-squidington-iii added 2 commits September 2, 2022 00:11

auto-bump connector version [ci skip]

a17600f

Merge branch 'liren/publish-s3' of https://github.com/airbytehq/airbyte…

a37ba72

… into liren/publish-s3

octavia-squidington-iii temporarily deployed to more-secrets September 2, 2022 00:14 Inactive

Revert databricks bump

e9c0952

tuliren temporarily deployed to more-secrets September 2, 2022 00:33 Inactive

octavia-squidington-iii added 2 commits September 2, 2022 00:52

auto-bump connector version [ci skip]

39089d1

Merge branch 'liren/publish-s3' of https://github.com/airbytehq/airbyte…

76c764e

… into liren/publish-s3

octavia-squidington-iii temporarily deployed to more-secrets September 2, 2022 00:55 Inactive

tuliren marked this pull request as ready for review September 2, 2022 01:05

tuliren requested a review from a team as a code owner September 2, 2022 01:05

tuliren merged commit fd547c6 into master Sep 2, 2022

tuliren deleted the liren/publish-s3 branch September 2, 2022 01:06

tuliren mentioned this pull request Sep 2, 2022

destination-s3: added possibly failing test case for Json Avro converter. #14492

Merged

37 tasks

octavia-squidington-iii mentioned this pull request Sep 2, 2022

Bump Airbyte version from 0.40.3 to 0.40.4 #16275

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Avro compatible destinations: fix field name clashing with combined restrict #16243

🐛 Avro compatible destinations: fix field name clashing with combined restrict #16243

tuliren commented Sep 1, 2022 •

edited

Loading

github-actions bot commented Sep 1, 2022 •

edited by tuliren

Loading

This comment was marked as outdated.

github-actions bot commented Sep 1, 2022

This comment was marked as outdated.

github-actions bot commented Sep 1, 2022

tuliren commented Sep 1, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

tuliren commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

🐛 Avro compatible destinations: fix field name clashing with combined restrict #16243

🐛 Avro compatible destinations: fix field name clashing with combined restrict #16243

Conversation

tuliren commented Sep 1, 2022 • edited Loading

What

Version bumps

github-actions bot commented Sep 1, 2022 • edited by tuliren Loading

This comment was marked as outdated.

github-actions bot commented Sep 1, 2022

This comment was marked as outdated.

github-actions bot commented Sep 1, 2022

tuliren commented Sep 1, 2022 • edited by github-actions bot Loading

github-actions bot commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

tuliren commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

tuliren commented Sep 1, 2022 •

edited

Loading

github-actions bot commented Sep 1, 2022 •

edited by tuliren

Loading

tuliren commented Sep 1, 2022 •

edited by github-actions bot

Loading