Log sync summary and sync activity seperators #16314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
evantahler
requested review from
davinchia,
alovew,
ChristopheDuong and
jdpgrailsdev
|
cc @erica-airbyte - hopefully this helps make the logs easier to parse! |
ChristopheDuong
approved these changes
Sep 6, 2022
davinchia
approved these changes
Sep 6, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Log activity start and end * pretty-print JSON replication and failure summaries * simplify
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Log activity start and end * pretty-print JSON replication and failure summaries * simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12864
This PR attempts to add some structure to our user-facing sync logs.
1. Clear separation of each Activity
2. Adding SyncSummaries and Failures to the log
Thanks, JSON pretty-printing!